linux-kernel - RE: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR03MB6253C3D92FFF37717D48C7618EBB9@SJ0PR03MB6253.namprd03.prod.outlook.com>
Date:   Wed, 29 Jun 2022 08:40:47 +0000
From:   "Hennerich, Michael" <Michael.Hennerich@...log.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Sa, Nuno" <Nuno.Sa@...log.com>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: RE: [PATCH v1 3/3] gpio: adp5588: sort header inclusion
 alphabetically



> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Sent: Dienstag, 28. Juni 2022 21:39
> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; linux-
> gpio@...r.kernel.org; linux-kernel@...r.kernel.org
> Cc: Hennerich, Michael <Michael.Hennerich@...log.com>; Linus Walleij
> <linus.walleij@...aro.org>; Bartosz Golaszewski <brgl@...ev.pl>
> Subject: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically
> 
> 
> Sort header inclusion alphabetically.

Hi Andy,

Thanks for the patches, they look good.
However, Nuno is currently working on getting the irqchip support into the
adp5588 input driver. In his patch series this driver is going away.

https://lore.kernel.org/linux-input/YpMCh1Xje+jsny8j@google.com/

Michael 

> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/gpio/gpio-adp5588.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c index
> d6a229a67044..d49f12560cde 100644
> --- a/drivers/gpio/gpio-adp5588.c
> +++ b/drivers/gpio/gpio-adp5588.c
> @@ -6,15 +6,15 @@
>   * Copyright 2009-2010 Analog Devices Inc.
>   */
> 
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/init.h>
> -#include <linux/i2c.h>
>  #include <linux/gpio/driver.h>
> +#include <linux/i2c.h>
> +#include <linux/init.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h>
> +#include <linux/kernel.h>
>  #include <linux/mod_devicetable.h>
>  #include <linux/module.h>
> +#include <linux/slab.h>
> 
>  #include <linux/platform_data/adp5588.h>
> 
> --
> 2.35.1