linux-kernel - RE: [PATCH v1 3/3] gpio: adp5588: sort header inclusion alphabetically

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR03MB67861277E1AE456A316DFFEB99BB9@PH0PR03MB6786.namprd03.prod.outlook.com>
Date:   Wed, 29 Jun 2022 10:09:58 +0000
From:   "Sa, Nuno" <Nuno.Sa@...log.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>
CC:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <brgl@...ev.pl>
Subject: RE: [PATCH v1 3/3] gpio: adp5588: sort header inclusion
 alphabetically

Hi Andy,

> From: Andy Shevchenko <andy.shevchenko@...il.com>
> Sent: Wednesday, June 29, 2022 12:00 PM
> To: Hennerich, Michael <Michael.Hennerich@...log.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>; linux-
> gpio@...r.kernel.org; linux-kernel@...r.kernel.org; Sa, Nuno
> <Nuno.Sa@...log.com>; Linus Walleij <linus.walleij@...aro.org>;
> Bartosz Golaszewski <brgl@...ev.pl>
> Subject: Re: [PATCH v1 3/3] gpio: adp5588: sort header inclusion
> alphabetically
> 
> [External]
> 
> On Wed, Jun 29, 2022 at 10:50 AM Hennerich, Michael
> <Michael.Hennerich@...log.com> wrote:
> >
> >
> >
> > > -----Original Message-----
> > > From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> > > Sent: Dienstag, 28. Juni 2022 21:39
> > > To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>;
> linux-
> > > gpio@...r.kernel.org; linux-kernel@...r.kernel.org
> > > Cc: Hennerich, Michael <Michael.Hennerich@...log.com>; Linus
> Walleij
> > > <linus.walleij@...aro.org>; Bartosz Golaszewski <brgl@...ev.pl>
> > > Subject: [PATCH v1 3/3] gpio: adp5588: sort header inclusion
> alphabetically
> > >
> > > Sort header inclusion alphabetically.
> >
> > Thanks for the patches, they look good.
> > However, Nuno is currently working on getting the irqchip support
> into the
> > adp5588 input driver. In his patch series this driver is going away.
> >
> > https://urldefense.com/v3/__https://lore.kernel.org/linux-
> input/YpMCh1Xje*jsny8j@...gle.com/__;Kw!!A3Ni8CS0y2Y!_Cb1uAs
> D-
> Z6iz_zSDfrd5Va6zLmdoxjv1vLYWQGHDOqYniaXVVHl3Ou2lOUQIjwhSN
> Ku2aZkYrOb8xMi2cZtfmsv$
> 
> While that work is ongoing, and most likely won't make v5.20-rc1, for
> the v5.20-rc1 I think my patches are good to go to avoid a bad (or
> rather very old) example on how to do GPIO drivers. What do you
> think?
> 

Just as note, If nothing unexpected happens, I'm planning in sending this
out today. If you still think this makes sense, fine by me. It's a very minimal
change that won't give much pain to deal with...

- Nuno Sá