lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Jun 2022 17:18:11 +0200 From: Greg Kroah-Hartman <gregkh@...uxfoundation.org> To: Yangxi Xiang <xyangxi5@...il.com> Cc: linux-kernel@...r.kernel.org, Jiri Slaby <jirislaby@...nel.org>, Johan Hovold <johan@...nel.org>, Igor Matheus Andrade Torrente <igormtorrente@...il.com>, Christian Borntraeger <borntraeger@...ux.ibm.com>, nick black <dankamongmen@...il.com> Subject: Re: [PATCH v3] vt: fix memory overlapping when deleting chars in the buffer On Tue, Jun 28, 2022 at 05:33:22PM +0800, Yangxi Xiang wrote: > A memory overlapping copy occurs when deleting a long line. This memory > overlapping copy can cause data corruption when scr_memcpyw is optimized > to memcpy because memcpy does not ensure its behavior if the destination > buffer overlaps with the source buffer. The line buffer is not always > broken, because the memcpy utilizes the hardware acceleration, whose > result is not deterministic. > > Fix this problem by using replacing the scr_memcpyw with scr_memmovew. > > Fixes: 81732c3b2fed ("Fix line garbage in virtual console") Nit, this should have been: Fixes: 81732c3b2fed ("tty vt: Fix line garbage in virtual console on command line edition") otherwise our tools complain. I've fixed it up when applying it. thanks, greg k-h
Powered by blists - more mailing lists