linux-kernel - Re: [PATCH] iio: adc: ti-adc128s052: Fix number of channels when device tree is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Jul 2022 16:18:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nishanth Menon <nm@...com>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jonathan Cameron <jic23@...nel.org>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ti-adc128s052: Fix number of channels when
 device tree is used

Hi Nishanth,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linus/master v5.19-rc4 next-20220630]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Nishanth-Menon/iio-adc-ti-adc128s052-Fix-number-of-channels-when-device-tree-is-used/20220701-070342
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: i386-randconfig-a002
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project a9119143a2d1f4d0d0bc1fe0d819e5351b4e0deb)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/d5184722ec9ae186da9bed1497e4804297f2040b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nishanth-Menon/iio-adc-ti-adc128s052-Fix-number-of-channels-when-device-tree-is-used/20220701-070342
        git checkout d5184722ec9ae186da9bed1497e4804297f2040b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/iio/adc/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/iio/adc/ti-adc128s052.c:185:43: warning: incompatible integer to pointer conversion initializing 'const void *' with an expression of type 'int' [-Wint-conversion]
           { .compatible = "ti,adc122s021", .data = 1},
                                                    ^
   drivers/iio/adc/ti-adc128s052.c:186:43: warning: incompatible integer to pointer conversion initializing 'const void *' with an expression of type 'int' [-Wint-conversion]
           { .compatible = "ti,adc122s051", .data = 1},
                                                    ^
   drivers/iio/adc/ti-adc128s052.c:187:43: warning: incompatible integer to pointer conversion initializing 'const void *' with an expression of type 'int' [-Wint-conversion]
           { .compatible = "ti,adc122s101", .data = 1},
                                                    ^
   drivers/iio/adc/ti-adc128s052.c:188:43: warning: incompatible integer to pointer conversion initializing 'const void *' with an expression of type 'int' [-Wint-conversion]
           { .compatible = "ti,adc124s021", .data = 2},
                                                    ^
   drivers/iio/adc/ti-adc128s052.c:189:43: warning: incompatible integer to pointer conversion initializing 'const void *' with an expression of type 'int' [-Wint-conversion]
           { .compatible = "ti,adc124s051", .data = 2},
                                                    ^
   drivers/iio/adc/ti-adc128s052.c:190:43: warning: incompatible integer to pointer conversion initializing 'const void *' with an expression of type 'int' [-Wint-conversion]
           { .compatible = "ti,adc124s101", .data = 2},
                                                    ^
   6 warnings generated.


vim +185 drivers/iio/adc/ti-adc128s052.c

   182	
   183	static const struct of_device_id adc128_of_match[] = {
   184		{ .compatible = "ti,adc128s052", .data = 0},
 > 185		{ .compatible = "ti,adc122s021", .data = 1},
   186		{ .compatible = "ti,adc122s051", .data = 1},
   187		{ .compatible = "ti,adc122s101", .data = 1},
   188		{ .compatible = "ti,adc124s021", .data = 2},
   189		{ .compatible = "ti,adc124s051", .data = 2},
   190		{ .compatible = "ti,adc124s101", .data = 2},
   191		{ /* sentinel */ },
   192	};
   193	MODULE_DEVICE_TABLE(of, adc128_of_match);
   194	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (163749 bytes)