linux-kernel - Re: [PATCH] iio: adc: ti-adc128s052: Fix number of channels when device tree is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfAMtb1jZHdLsb=TtajGC6WFZ0z-5k31Vy=cG7ytjByTg@mail.gmail.com>
Date:   Fri, 1 Jul 2022 12:08:05 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Nishanth Menon <nm@...com>
Cc:     Javier Martinez Canillas <javier@....samsung.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Alexandru Ardelean <ardeleanalex@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Jonathan Cameron <jic23@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        Stable <stable@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: ti-adc128s052: Fix number of channels when
 device tree is used

On Fri, Jul 1, 2022 at 5:41 AM Nishanth Menon <nm@...com> wrote:
> On 18:01-20220630, Nishanth Menon wrote:

...

> >  static const struct of_device_id adc128_of_match[] = {
> > -     { .compatible = "ti,adc128s052", },
> > -     { .compatible = "ti,adc122s021", },
> > -     { .compatible = "ti,adc122s051", },
> > -     { .compatible = "ti,adc122s101", },
> > -     { .compatible = "ti,adc124s021", },
> > -     { .compatible = "ti,adc124s051", },
> > -     { .compatible = "ti,adc124s101", },
> > +     { .compatible = "ti,adc128s052", .data = 0},
>
> I should probably cast these as .data = (void *)0 thoughts?

The 0 is default. You shouldn't use that in the first place for
something meaningful rather than "no, we have no driver data for this
chip).

-- 
With Best Regards,
Andy Shevchenko