lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 Jul 2022 16:47:44 +0800 From: David Gow <davidgow@...gle.com> To: Brendan Higgins <brendanhiggins@...gle.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Jonathan Corbet <corbet@....net>, Andrew Morton <akpm@...ux-foundation.org>, Kees Cook <keescook@...omium.org>, Shuah Khan <skhan@...uxfoundation.org>, Greg KH <gregkh@...uxfoundation.org>, Luis Chamberlain <mcgrof@...nel.org>, Masahiro Yamada <masahiroy@...nel.org> Cc: David Gow <davidgow@...gle.com>, "Guilherme G . Piccoli" <gpiccoli@...lia.com>, Sebastian Reichel <sre@...nel.org>, John Ogness <john.ogness@...utronix.de>, Joe Fradley <joefradley@...gle.com>, Daniel Latypov <dlatypov@...gle.com>, kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, Jani Nikula <jani.nikula@...ux.intel.com>, Lucas De Marchi <lucas.demarchi@...el.com>, Aaron Tomlin <atomlin@...hat.com>, linux-fsdevel@...r.kernel.org, linux-block@...r.kernel.org, Michal Marek <michal.lkml@...kovi.net>, Nick Desaulniers <ndesaulniers@...gle.com>, linux-kbuild@...r.kernel.org Subject: [PATCH v4 4/4] selftest: Taint kernel when test module loaded Make any kselftest test module (using the kselftest_module framework) taint the kernel with TAINT_TEST on module load. Note that several selftests use kernel modules which are not based on the kselftest_module framework, and so will not automatically taint the kernel. This can be done in two ways: - Moving the module to the tools/testing directory. All modules under this directory will taint the kernel. - Adding the 'test' module property with: MODULE_INFO(test, "Y") Similarly, selftests which do not load modules into the kernel generally should not taint the kernel (or possibly should only do so on failure), as it's assumed that testing from user-space should be safe. Regardless, they can write to /proc/sys/kernel/tainted if required. Signed-off-by: David Gow <davidgow@...gle.com> --- This still only covers a subset of selftest modules, but combined with the modpost check for the tools/testing path, it should catch many future tests. Others can be moved, adapted to use this framework, or have MODULE_INFO(test, "Y") added. (Alas, I don't have the time to hunt down all of the tests which don't do this at the moment. No changes since v3: https://lore.kernel.org/lkml/20220513083212.3537869-3-davidgow@google.com/ --- tools/testing/selftests/kselftest_module.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/testing/selftests/kselftest_module.h b/tools/testing/selftests/kselftest_module.h index e2ea41de3f35..226e616b82e0 100644 --- a/tools/testing/selftests/kselftest_module.h +++ b/tools/testing/selftests/kselftest_module.h @@ -3,6 +3,7 @@ #define __KSELFTEST_MODULE_H #include <linux/module.h> +#include <linux/panic.h> /* * Test framework for writing test modules to be loaded by kselftest. @@ -41,6 +42,7 @@ static inline int kstm_report(unsigned int total_tests, unsigned int failed_test static int __init __module##_init(void) \ { \ pr_info("loaded.\n"); \ + add_taint(TAINT_KUNIT, LOCKDEP_STILL_OK); \ selftest(); \ return kstm_report(total_tests, failed_tests, skipped_tests); \ } \ -- 2.37.0.rc0.161.g10f37bed90-goog
Powered by blists - more mailing lists