linux-kernel - Re: [PATCH 1/8] arm: align find_bit declarations with generic kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YsAyTNMvCNLeDZY/@smile.fi.intel.com>
Date:   Sat, 2 Jul 2022 14:55:56 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Yury Norov <yury.norov@...il.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Howells <dhowells@...hat.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jonathan Corbet <corbet@....net>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        NeilBrown <neilb@...e.de>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Russell King <linux@...linux.org.uk>,
        Vlastimil Babka <vbabka@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>,
        linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mm@...ck.org
Subject: Re: [PATCH 1/8] arm: align find_bit declarations with generic kernel

On Fri, Jul 01, 2022 at 05:54:23AM -0700, Yury Norov wrote:
> ARM has their own implementation for find_bit functions, and function
> declarations are different with those in generic headers. Fix it.

...

> -extern int _find_first_zero_bit_le(const unsigned long *p, unsigned size);
> -extern int _find_next_zero_bit_le(const unsigned long *p, int size, int offset);
> -extern int _find_first_bit_le(const unsigned long *p, unsigned size);
> -extern int _find_next_bit_le(const unsigned long *p, int size, int offset);
> +unsigned long  _find_first_zero_bit_le(const unsigned long *p, unsigned long size);
> +unsigned long  _find_next_zero_bit_le(const unsigned long *p,
> +					unsigned long size, unsigned long offset);
> +unsigned long  _find_first_bit_le(const unsigned long *p, unsigned long size);

> +unsigned long  _find_next_bit_le(const unsigned long *p,
> +					unsigned long size, unsigned long offset);

Indentation seems broken.

Also for all: is double space required?


...

> +unsigned long _find_next_bit_be(const unsigned long *p,
> +					unsigned long size, unsigned long offset);

Indentation of the second line is broken (u in 'unsigned' should be in the same
column as 'const').

-- 
With Best Regards,
Andy Shevchenko