linux-kernel - Re: [PATCH v3 0/9] drm: selftest: Convert to KUnit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9185aadb-e459-00fe-70be-3675f6f3ef4c@redhat.com>
Date:   Sat, 2 Jul 2022 13:56:27 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Maíra Canal <maira.canal@....br>,
        Isabella Basso <isabbasso@...eup.net>, magalilemes00@...il.com,
        tales.aparecida@...il.com, mwen@...lia.com, andrealmeid@...eup.net,
        siqueirajordao@...eup.net, Trevor Woerner <twoerner@...il.com>,
        leandro.ribeiro@...labora.com, n@...aprado.net,
        Daniel Vetter <daniel@...ll.ch>,
        Shuah Khan <skhan@...uxfoundation.org>,
        David Airlie <airlied@...ux.ie>,
        Maxime Ripard <mripard@...nel.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        michal.winiarski@...el.com,
        José Expósito <jose.exposito89@...il.com>,
        David Gow <davidgow@...gle.com>,
        Daniel Latypov <dlatypov@...gle.com>, brendanhiggins@...gle.com
Cc:     kunit-dev@...glegroups.com, linux-kselftest@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/9] drm: selftest: Convert to KUnit

On 6/30/22 02:46, Maíra Canal wrote:
> Hi everyone,
> 
> Here is the v3 of the conversion of selftests to KUnit. Since the v2, there
> have been minor fixes. drm_format_test received the biggest change: the
> KUNIT_EXPECT_FALSE and KUNIT_EXPECT_TRUE macros were changed to KUNIT_EXPECT_EQ,
> as suggested by Daniel.
> 
> Most of all, the patches were rebased on top of the recently applied patches
> for drm_format_helper tests (8f456104915f), in order to avoid conflicts when
> applying the tests.
> 
> Thanks for your attention and any feedback is welcomed!
> 
> Best Regards,
> - Maíra Canal
>

Thanks a lot for working on this! The patches look good to me, I just had some
minor comments. If you re-spin, I think that we can just push the whole series
to drm-misc since the patches have been in the mailing list for some time and
have already been tested/reviewed.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat