linux-kernel - Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where appropriate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YsC/yRH1HLHvDlIS@yury-laptop>
Date:   Sat, 2 Jul 2022 14:59:37 -0700
From:   Yury Norov <yury.norov@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Howells <dhowells@...hat.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jonathan Corbet <corbet@....net>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        NeilBrown <neilb@...e.de>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Russell King <linux@...linux.org.uk>,
        Vlastimil Babka <vbabka@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>,
        linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mm@...ck.org
Subject: Re: [PATCH 5/8] lib/cpumask: change return types to unsigned where
 appropriate

On Sat, Jul 02, 2022 at 03:00:19PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 01, 2022 at 05:54:27AM -0700, Yury Norov wrote:
> > Switch return types to unsigned int where return values cannot be negative.
> 
> ...
> 
> > -int cpumask_any_and_distribute(const struct cpumask *src1p,
> > +unsigned int cpumask_any_and_distribute(const struct cpumask *src1p,
> >  			       const struct cpumask *src2p);
> 
> It breaks indentation of the second line.

I'd prefer to keep 2nd line untouched to not trash history for
nothing.

> 
> ...
> 
> > -int cpumask_next_and(int n, const struct cpumask *src1p,
> > +unsigned int cpumask_next_and(int n, const struct cpumask *src1p,
> >  		     const struct cpumask *src2p)
> 
> Ditto.
> 
> And seems a lot of cases in the series like this.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
>