linux-kernel - Re: [PATCH 7/8] mm: split include/linux/gfp.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YsDBb15JeN2v/NBK@yury-laptop>
Date:   Sat, 2 Jul 2022 15:06:39 -0700
From:   Yury Norov <yury.norov@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Howells <dhowells@...hat.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>,
        Jonathan Corbet <corbet@....net>,
        "Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
        Matthew Wilcox <willy@...radead.org>,
        NeilBrown <neilb@...e.de>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Russell King <linux@...linux.org.uk>,
        Vlastimil Babka <vbabka@...e.cz>,
        William Kucharski <william.kucharski@...cle.com>,
        linux-doc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mm@...ck.org
Subject: Re: [PATCH 7/8] mm: split include/linux/gfp.h

On Sat, Jul 02, 2022 at 03:09:40PM +0300, Andy Shevchenko wrote:
> On Sat, Jul 02, 2022 at 03:05:39PM +0300, Andy Shevchenko wrote:
> > On Fri, Jul 01, 2022 at 05:54:29AM -0700, Yury Norov wrote:
> > > gfp.h belongs to many include paths, and it causes circular dependencies
> > > when, for example, trying to keep cpumask one-line wrappers in headers.
> > > 
> > > In many cases, sources need only gfp flags. This patch splits gfp.h by
> > > moving flags to include/linux/gfp_flags.h. It helps to move trivial 
> > > wrappers from c-file to header in the following patch for cpumask.
> > 
> > Wondering if you checked Ingo's gigantic series [1] for something similar.
> > Maybe you may utilize his work if there is anything like this.

No, I didn't. 

> > 
> > [1]: https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/log/?h=sched/headers
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/mingo/tip.git/commit/?h=sched/headers&id=56a20d45417dc517d91626e5ef9f5492a5e901aa
> and a few more patches on top

OK, I'll try to use his patches. If they don't work - I'll take mine.

> -- 
> With Best Regards,
> Andy Shevchenko
>