linux-kernel - Re: [PATCH v3 2/6] Staging: rtl8192e: Avoid multiple assignments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7232163c-f573-c1f8-5cd1-da5b70e76091@gmail.com>
Date:   Sat, 2 Jul 2022 08:08:25 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Felix Schlepper <f3sch.git@...look.com>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        wjsota@...il.com
Subject: Re: [PATCH v3 2/6] Staging: rtl8192e: Avoid multiple assignments

On 7/1/22 11:24, Felix Schlepper wrote:
> This addresses an issue raised by checkpatch.pl:
> 
>       $ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
>       CHECK: multiple assignments should be avoided
> 
> Signed-off-by: Felix Schlepper <f3sch.git@...look.com>
> ---
>   drivers/staging/rtl8192e/rtllib_wx.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index b7f19b38b0e1..121bf939c6a4 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -149,7 +149,8 @@ static inline char *rtl819x_translate_scan(struct rtllib_device *ieee,
>   			max_rate = rate;
>   	}
>   	iwe.cmd = SIOCGIWRATE;
> -	iwe.u.bitrate.fixed = iwe.u.bitrate.disabled = 0;
> +	iwe.u.bitrate.disabled = 0;
> +	iwe.u.bitrate.fixed = 0;
>   	iwe.u.bitrate.value = max_rate * 500000;
>   	start = iwe_stream_add_event_rsl(info, start, stop, &iwe, IW_EV_PARAM_LEN);
>   	iwe.cmd = IWEVCUSTOM;


Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>