linux-kernel - Re: [PATCH v3 3/6] Staging: rtl8192e: Remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9c7673b3-29ec-8a4d-0571-c869bc60b567@gmail.com>
Date:   Sat, 2 Jul 2022 08:09:01 +0200
From:   Philipp Hortmann <philipp.g.hortmann@...il.com>
To:     Felix Schlepper <f3sch.git@...look.com>, gregkh@...uxfoundation.org
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        wjsota@...il.com
Subject: Re: [PATCH v3 3/6] Staging: rtl8192e: Remove unnecessary parentheses

On 7/1/22 11:24, Felix Schlepper wrote:
> This addresses an issue raised by checkpatch.pl:
> 
>       $ ./scripts/checkpatch.pl --terse -f drivers/staging/rtl8192e/rtllib_wx.c
>       Unnecessary parentheses around wrqu->encoding
> 
> Signed-off-by: Felix Schlepper <f3sch.git@...look.com>
> ---
>   drivers/staging/rtl8192e/rtllib_wx.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c
> index 121bf939c6a4..db076e819993 100644
> --- a/drivers/staging/rtl8192e/rtllib_wx.c
> +++ b/drivers/staging/rtl8192e/rtllib_wx.c
> @@ -277,7 +277,7 @@ int rtllib_wx_set_encode(struct rtllib_device *ieee,
>   			 struct iw_request_info *info,
>   			 union iwreq_data *wrqu, char *keybuf)
>   {
> -	struct iw_point *erq = &(wrqu->encoding);
> +	struct iw_point *erq = &wrqu->encoding;
>   	struct net_device *dev = ieee->dev;
>   	struct rtllib_security sec = {
>   		.flags = 0
> @@ -449,7 +449,7 @@ int rtllib_wx_get_encode(struct rtllib_device *ieee,
>   			 struct iw_request_info *info,
>   			 union iwreq_data *wrqu, char *keybuf)
>   {
> -	struct iw_point *erq = &(wrqu->encoding);
> +	struct iw_point *erq = &wrqu->encoding;
>   	int len, key;
>   	struct lib80211_crypt_data *crypt;
>   

Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>