linux-kernel - RE: [PATCH v3 2/2] scsi: ufs: wb: Add Manual Flush sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR04MB65759980842FAB4A3C7D013BFCBF9@DM6PR04MB6575.namprd04.prod.outlook.com>
Date:   Sun, 3 Jul 2022 13:08:52 +0000
From:   Avri Altman <Avri.Altman@....com>
To:     "j-young.choi@...sung.com" <j-young.choi@...sung.com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3 2/2] scsi: ufs: wb: Add Manual Flush sysfs

> There is the following quirk to bypass "WB Manual Flush" in Write Booster.
> 
>         - UFSHCI_QUIRK_SKIP_MANUAL_WB_FLUSH_CTRL
> 
> If this quirk is not set, there is no knob that can control "WB Manual Flush".
> 
> There are three flags that control Write Booster Feature.
>         1. WB ON/OFF
>         2. WB Hibern Flush ON/OFF
>         3. WB Flush ON/OFF
> 
> The sysfs that controls the WB was implemented. (1)
> 
> In the case of "Hibern Flush", it is always good to turn on.
> Control may not be required. (2)
> 
> Finally, "Manual flush" may be necessary because the Auto-Hibern8 is not
> supported in a specific environment.
> So the sysfs that controls this is necessary. (3)
> 
> Signed-off-by: Jinyoung Choi <j-young.choi@...sung.com>
Reviewed-by: Avri Altman <avri.altman@....com>