linux-kernel - RE:(2) [PATCH v3 1/2] scsi: ufs: wb: renaming & cleanups functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220704024414epcms2p206c70583f57d8df4f41f36a1e686475a@epcms2p2>
Date:   Mon, 04 Jul 2022 11:44:14 +0900
From:   Jinyoung CHOI <j-young.choi@...sung.com>
To:     Avri Altman <Avri.Altman@....com>,
        ALIM AKHTAR <alim.akhtar@...sung.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "beanhuo@...ron.com" <beanhuo@...ron.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE:(2) [PATCH v3 1/2] scsi: ufs: wb: renaming & cleanups functions

>> @@ -5715,6 +5715,9 @@ static int __ufshcd_wb_toggle(struct ufs_hba *hba,
>> bool set, enum flag_idn idn)
>>         enum query_opcode opcode = set ? UPIU_QUERY_OPCODE_SET_FLAG :
>>                                    UPIU_QUERY_OPCODE_CLEAR_FLAG;
>> 
>> +       if (!ufshcd_is_wb_allowed(hba))
>> +               return -EPERM;
>> +
>>         index = ufshcd_wb_get_query_index(hba);
>>         return ufshcd_query_flag_retry(hba, opcode, idn, index, NULL);  } @@ -
>> 5723,60 +5726,50 @@ int ufshcd_wb_toggle(struct ufs_hba *hba, bool
>> enable)  {
> Nobody is checking the return value of ufshcd_wb_toggle(), maybe make it void instead?
>
> Other than that - looks good to me.
>
> Reviewed-by: Avri Altman <avri.altman@....com>

It is used in "wb_on_store()" that turns WB on/off.

Thank you for your review. :)

Jinyoung.