lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Jul 2022 14:14:21 -0700 From: Brad Larson <brad@...sando.io> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, linux-mmc <linux-mmc@...r.kernel.org>, Adrian Hunter <adrian.hunter@...el.com>, Al Cooper <alcooperx@...il.com>, Arnd Bergmann <arnd@...db.de>, blarson@....com, Catalin Marinas <catalin.marinas@....com>, Gabriel Somlo <gsomlo@...il.com>, gerg@...ux-m68k.org, Krzysztof Kozlowski <krzk@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Lee Jones <lee.jones@...aro.org>, Mark Brown <broonie@...nel.org>, Masahiro Yamada <yamada.masahiro@...ionext.com>, Philipp Zabel <p.zabel@...gutronix.de>, Pratyush Yadav <p.yadav@...com>, Randy Dunlap <rdunlap@...radead.org>, Rob Herring <robh+dt@...nel.org>, samuel@...lland.org, Serge Semin <fancer.lancer@...il.com>, suravee.suthikulpanit@....com, Tom Lendacky <thomas.lendacky@....com>, Ulf Hansson <ulf.hansson@...aro.org>, Will Deacon <will@...nel.org>, devicetree <devicetree@...r.kernel.org> Subject: Re: [PATCH v5 12/15] spi: dw: Add support for AMD Pensando Elba SoC Hi Andy, On Tue, Jun 14, 2022 at 4:10 AM Andy Shevchenko <andy.shevchenko@...il.com> wrote: > > On Mon, Jun 13, 2022 at 9:57 PM Brad Larson <brad@...sando.io> wrote: > ... > > > +/* > > + * Elba SoC does not use ssi, pin override is used for cs 0,1 and > > + * gpios for cs 2,3 as defined in the device tree. > > + * > > + * cs: | 1 0 > > + * bit: |---3-------2-------1-------0 > > + * | cs1 cs1_ovr cs0 cs0_ovr > > + */ > > > +#define ELBA_SPICS_SHIFT(cs) (2 * (cs)) > > Useless.It takes much more than simply multiplying each time in two > macros. Also see below. > > > +#define ELBA_SPICS_MASK(cs) (0x3 << ELBA_SPICS_SHIFT(cs)) > > (GENMASK(1, 0) << ((cs) << 1)) > > Or ((cs) * 2) to show that it takes 2 bits and not two times of CS', > > > +#define ELBA_SPICS_SET(cs, val) \ > > + ((((val) << 1) | 0x1) << ELBA_SPICS_SHIFT(cs)) > > BIT(0) > > So the main point is to use GENMASK() and BIT() the rest is up to you. I think you're recommending this approach which I'll change to static void dw_spi_elba_override_cs(struct dw_spi_elba *dwselba, int cs, int enable) { regmap_update_bits(dwselba->syscon, ELBA_SPICS_REG, (GENMASK(1, 0) << ((cs) << 1)), ((enable) << 1 | BIT(0)) << ((cs) << 1)); } Regards, Brad
Powered by blists - more mailing lists