linux-kernel - Re: [PATCH v11 09/14] module: Move kallsyms support into a separate file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220703191837.0157546d@gandalf.local.home>
Date:   Sun, 3 Jul 2022 19:18:37 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Aaron Tomlin <atomlin@...hat.com>,
        Luis Chamberlain <mcgrof@...nel.org>,
        "cl@...ux.com" <cl@...ux.com>, "mbenes@...e.cz" <mbenes@...e.cz>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "jeyu@...nel.org" <jeyu@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "void@...ifault.com" <void@...ifault.com>,
        "atomlin@...mlin.com" <atomlin@...mlin.com>,
        "allen.lkml@...il.com" <allen.lkml@...il.com>,
        "joe@...ches.com" <joe@...ches.com>,
        "msuchanek@...e.de" <msuchanek@...e.de>,
        "oleksandr@...alenko.name" <oleksandr@...alenko.name>,
        "jason.wessel@...driver.com" <jason.wessel@...driver.com>,
        "pmladek@...e.com" <pmladek@...e.com>,
        "daniel.thompson@...aro.org" <daniel.thompson@...aro.org>,
        "hch@...radead.org" <hch@...radead.org>,
        Chuck Lever III <chuck.lever@...cle.com>
Subject: Re: [PATCH v11 09/14] module: Move kallsyms support into a separate
 file

On Sun, 3 Jul 2022 17:58:15 +0000
Christophe Leroy <christophe.leroy@...roup.eu> wrote:

> When I started submitting Kernel patches years ago, I was given those 
> guidelines:
> - Always submit checkpatch clean patches.
> - Try to never modify the same line of code twice in a series.
> 
> Which implied to always fix codying Style while changing or moving code.

Yeah, I figured as much. I'll go back and read the coding style and see if
it mentions this. If not, it needs to be updated.

The exception is when you move code. Code moving should never have any
other changes to it, because it makes it much more difficult to know what
changed.

-- Steve