linux-kernel - [PATCH -next] gpio: pxa: Add missing clk_disable_unprepare() in pxa_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220704130323.104294-1-yuancan@huawei.com>
Date:   Mon, 4 Jul 2022 13:03:23 +0000
From:   Yuan Can <yuancan@...wei.com>
To:     <linux-gpio@...r.kernel.org>
CC:     <brgl@...ev.pl>, <linus.walleij@...aro.org>,
        <robert.jarzmik@...e.fr>, <linux-kernel@...r.kernel.org>,
        <yuancan@...wei.com>
Subject: [PATCH -next] gpio: pxa: Add missing clk_disable_unprepare() in pxa_gpio_probe()

Add clk_disable_unprepare() on error path in pxa_gpio_probe().

Reported-by: Hulk Robot <hulkci@...wei.com>
Signed-off-by: Yuan Can <yuancan@...wei.com>
---
 drivers/gpio/gpio-pxa.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/gpio-pxa.c b/drivers/gpio/gpio-pxa.c
index c7fbfa3ae43b..08963975dd1b 100644
--- a/drivers/gpio/gpio-pxa.c
+++ b/drivers/gpio/gpio-pxa.c
@@ -676,6 +676,7 @@ static int pxa_gpio_probe(struct platform_device *pdev)
 	/* Initialize GPIO chips */
 	ret = pxa_init_gpio_chip(pchip, pxa_last_gpio + 1, gpio_reg_base);
 	if (ret) {
+		clk_disable_unprepare(clk);
 		clk_put(clk);
 		return ret;
 	}
-- 
2.17.1