[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8afa9243-b216-ac6c-66d1-2509845de17c@microchip.com>
Date: Mon, 4 Jul 2022 13:32:13 +0000
From: <Sergiu.Moga@...rochip.com>
To: <krzysztof.kozlowski@...aro.org>, <broonie@...nel.org>,
<robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
<Nicolas.Ferre@...rochip.com>, <alexandre.belloni@...tlin.com>,
<Claudiu.Beznea@...rochip.com>
CC: <linux-spi@...r.kernel.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>, <Kavyasree.Kotagiri@...rochip.com>,
<UNGLinuxDriver@...rochip.com>, <Tudor.Ambarus@...rochip.com>
Subject: Re: [PATCH v2] spi: atmel: convert spi_atmel to json-schema
On 04.07.2022 15:52, Krzysztof Kozlowski wrote:
> On 04/07/2022 10:31, Sergiu Moga wrote:
>> Convert SPI DT binding for Atmel/Microchip SoCs to YAML schema.
>>
>> Signed-off-by: Sergiu Moga <sergiu.moga@...rochip.com>
>> ---
>>
>> v1 -> v2:
>> - change subject headline prefix from "dt-bindings: spi" to "spi: atmel"
> Should be:
> spi: dt-bindings: atmel,spi: convert to json-schema
> (or to DT schema)
>
Noted.
>> - change maintainer
>> - kept the compatbile as items (instead of switching to enums) and at91rm9200
>> as fallback for sam9x60, since the evolution of IP's is incremental.
>> - removed unnecessay "cs-gpios" property and descriptions
>> - added min/max for fifo-size property.
>>
>>
>> .../devicetree/bindings/spi/atmel,spi.yaml | 77 +++++++++++++++++++
>> .../devicetree/bindings/spi/spi_atmel.txt | 36 ---------
>> 2 files changed, 77 insertions(+), 36 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/spi/atmel,spi.yaml
>> delete mode 100644 Documentation/devicetree/bindings/spi/spi_atmel.txt
>>
>> diff --git a/Documentation/devicetree/bindings/spi/atmel,spi.yaml b/Documentation/devicetree/bindings/spi/atmel,spi.yaml
>> new file mode 100644
>> index 000000000000..d627fc9315bc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/spi/atmel,spi.yaml
>> @@ -0,0 +1,77 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/spi/atmel,spi.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Atmel SPI device
>> +
>> +maintainers:
>> + - Tudor Ambarus <tudor.ambarus@...rochip.com>
>> +
>> +allOf:
>> + - $ref: spi-controller.yaml#
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> + - items:
>> + - const: atmel,at91rm9200-spi
>> + - items:
>> + - const: microchip,sam9x60-spi
>> + - const: atmel,at91rm9200-spi
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + clock-names:
>> + contains:
>> + const: spi_clk
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + atmel,fifo-size:
>> + $ref: /schemas/types.yaml#/definitions/uint32
>> + description: |
>> + Maximum number of data the RX and TX FIFOs can store for FIFO
>> + capable SPI controllers.
>> + minimum: 16
>> + maximum: 32
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - interrupts
>> + - clock-names
>> + - clocks
> In properties it's clock-names followed by clocks, so better to keep
> same order here.
I am sorry, but I don't quite understand. Isn't it the same already (the
order in properties and the order in required)?
>> +
>> +unevaluatedProperties: false
>> +
>
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> Best regards,
> Krzysztof
Regards,
Sergiu
Powered by blists - more mailing lists