[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20220704133656.2676043-1-foxhoundsk.tw@gmail.com>
Date: Mon, 4 Jul 2022 21:36:56 +0800
From: Huichun Feng <foxhoundsk.tw@...il.com>
To: Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Juri Lelli <juri.lelli@...hat.com>,
Vincent Guittot <vincent.guittot@...aro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@....com>,
Steven Rostedt <rostedt@...dmis.org>,
Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
Daniel Bristot de Oliveira <bristot@...hat.com>,
Valentin Schneider <vschneid@...hat.com>,
linux-kernel@...r.kernel.org (open list:SCHEDULER),
jserv@...s.ncku.edu.tw, Chin-En Lin <shiyn.lin@...il.com>,
foxhoundsk.tw@...il.com
Subject: [PATCH v2 RESEND] sched/fair: avoid redundant hrtimer check
The check is required iff HRTICK is enabled and DOUBLE_TICK is disabled,
don't do that then.
Signed-off-by: Huichun Feng <foxhoundsk.tw@...il.com>
---
Changes since v1:
- Refine commit message
v1 link: https://lore.kernel.org/linux-kernel/20220606122612.2580930-1-foxhoundsk.tw@gmail.com/
Sorry, I shouldn't send v2 in the same thread.
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 77b2048a9..80cc1a924 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4668,7 +4668,7 @@ entity_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr, int queued)
/*
* don't let the period tick interfere with the hrtick preemption
*/
- if (!sched_feat(DOUBLE_TICK) &&
+ if (sched_feat(HRTICK) && !sched_feat(DOUBLE_TICK) &&
hrtimer_active(&rq_of(cfs_rq)->hrtick_timer))
return;
#endif
--
2.36.1
Powered by blists - more mailing lists