linux-kernel - Re: [PATCH V3 10/10] arm64: dts: imx8mp: add NoC node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36d8fbe2-b64d-4997-5836-b2c32e4d987f@kernel.org>
Date:   Mon, 4 Jul 2022 16:50:51 +0300
From:   Georgi Djakov <djakov@...nel.org>
To:     "Peng Fan (OSS)" <peng.fan@....nxp.com>, shawnguo@...nel.org,
        s.hauer@...gutronix.de, festevam@...il.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, abel.vesa@....com,
        abailon@...libre.com, l.stach@...gutronix.de,
        laurent.pinchart@...asonboard.com, marex@...x.de,
        paul.elder@...asonboard.com, Markus.Niebel@...tq-group.com,
        aford173@...il.com, cw00.choi@...sung.com,
        kyungmin.park@...sung.com, myungjoo.ham@...sung.com
Cc:     kernel@...gutronix.de, linux-pm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org, linux-imx@....com,
        abelvesa@...nel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH V3 10/10] arm64: dts: imx8mp: add NoC node


Hi Peng,

On 3.07.22 12:11, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
> 
> Add i.MX8MP NoC node to make the interconnect i.MX8MP driver could work.
> Currently dynamic frequency scaling of the i.MX8MP NoC has not been
> supported, only NoC initial settings are configured by interconnect
> driver.
> 
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
>   arch/arm64/boot/dts/freescale/imx8mp.dtsi | 22 ++++++++++++++++++++++
>   1 file changed, 22 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index eb2d516278eb..13a2ee77d3c6 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -4,6 +4,7 @@
>    */
>   
>   #include <dt-bindings/clock/imx8mp-clock.h>
> +#include <dt-bindings/interconnect/fsl,imx8mp.h>

It's also possible to drop this line for now and add it in the next patches when we add the 
interconnect consumers. This will allow merging this DT patch independently. But it's up to Shawn.

>   #include <dt-bindings/power/imx8mp-power.h>
>   #include <dt-bindings/gpio/gpio.h>
>   #include <dt-bindings/input/input.h>
> @@ -1019,6 +1020,27 @@ eqos: ethernet@...f0000 {
>   			};
>   		};
>   
> +		noc: interconnect@...00000 {
> +			compatible = "fsl,imx8mp-noc", "fsl,imx8m-noc", "syscon";

I got the impression that we are dropping the syscon, or not?

> +			reg = <0x32700000 0x100000>;
> +			clocks = <&clk IMX8MP_CLK_NOC>;
> +			#interconnect-cells = <1>;
> +
> +			operating-points-v2 = <&noc_opp_table>;
> +
> +			noc_opp_table: opp-table {
> +				compatible = "operating-points-v2";
> +
> +				opp-200M {
> +					opp-hz = /bits/ 64 <200000000>;
> +				};
> +
> +				opp-1000M {
> +					opp-hz = /bits/ 64 <1000000000>;
> +				};
> +			};
> +		};
> +
>   		aips4: bus@...00000 {
>   			compatible = "fsl,aips-bus", "simple-bus";
>   			reg = <0x32c00000 0x400000>;
Patches 1-9 look good and I am planning to merge them.

Thanks,
Georgi