linux-kernel - Re: [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jul 2022 18:26:39 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     <Ryan.Wanner@...rochip.com>, <Claudiu.Beznea@...rochip.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <lgirdwood@...il.com>,
        <devicetree@...r.kernel.org>, <krzysztof.kozlowski+dt@...aro.org>,
        <robh+dt@...nel.org>, <broonie@...nel.org>,
        <alsa-devel@...a-project.org>
Subject: Re: [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add
 nodes for I2S controllers")

Hi Ryan,

On 06/07/2022 at 18:21, Ryan.Wanner@...rochip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@...rochip.com>
> 
> Fixed typo in i2s1 node
> 
> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>

The "Fixes" tag should go there in this section of the email, and not 
replace the subject.

One example of the subject could be:
"[PATCH v2] ARM: dts: at91: sama5d2: fix typo in i2s1 node"

> ---
> Changes since v1:
> 1. Corrected commit

You can place this content about changes...

> ---

Just here, below the "---", so that you don't need to add another "---".

Regards,
   Nicolas

>   arch/arm/boot/dts/sama5d2.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 89c71d419f82..659a17fc755c 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -1124,7 +1124,7 @@ AT91_XDMAC_DT_PERID(33))>,
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 55>, <&pmc PMC_TYPE_GCK 55>;
>   				clock-names = "pclk", "gclk";
>   				assigned-clocks = <&pmc PMC_TYPE_CORE PMC_I2S1_MUX>;
> -				assigned-parrents = <&pmc PMC_TYPE_GCK 55>;
> +				assigned-clock-parents = <&pmc PMC_TYPE_GCK 55>;
>   				status = "disabled";
>   			};
>   


-- 
Nicolas Ferre