linux-kernel - Re: [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add nodes for I2S controllers")

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d318e4d1-fdf8-e6d0-8dec-bf05c4e9aa59@intel.com>
Date:   Wed, 6 Jul 2022 22:06:42 +0200
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     <Ryan.Wanner@...rochip.com>, <Claudiu.Beznea@...rochip.com>,
        <nicolas.ferre@...rochip.com>, <alexandre.berna@...rochip.com>,
        <robh+dt@...nel.org>, <broonie@...nel.org>, <lgirdwood@...il.com>,
        <alsa-devel@...a-project.org>, <krzysztof.kozlowski+dt@...aro.org>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <devicetree@...r.kernel.org>
Subject: Re: [PATCH v2] Fixes: 1ca81883c557 ("ARM: dts: at91: sama5d2: add
 nodes for I2S controllers")

On 2022-07-06 6:21 PM, Ryan.Wanner@...rochip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@...rochip.com>
> 
> Fixed typo in i2s1 node

Perhaps this email got twisted by my client but what I'm seeing is 
fixes-tag instead of a proper commit title.

If that's really the case, please reword your title - Fixes-tag belongs 
to the tag area and should be placed before your final signed-off tag.

Also, as commit message is _not_ a title and is made of sentences, it is 
expected to have each end with '.'.
Another suggestion - nothing is "Fixed" when patch lands on the mailing 
list. It's just a proposal until it actually gets integrated by the 
maintainer. As change targets _current_ code, s/Fixed/Fix/ is the 
recommended phrasing.

Czarek

> Signed-off-by: Ryan Wanner <Ryan.Wanner@...rochip.com>