linux-kernel - Re: [PATCH 5.15 96/98] hwmon: (occ) Remove sequence numbering and checksum calculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jul 2022 09:02:43 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Joel Stanley <joel@....id.au>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable@...r.kernel.org, Eddie James <eajames@...ux.ibm.com>,
        Guenter Roeck <linux@...ck-us.net>,
        Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH 5.15 96/98] hwmon: (occ) Remove sequence numbering and
 checksum calculation

On Wed, Jul 06, 2022 at 06:43:47AM +0000, Joel Stanley wrote:
> On Tue, 5 Jul 2022 at 12:14, Greg Kroah-Hartman
> <gregkh@...uxfoundation.org> wrote:
> >
> > From: Eddie James <eajames@...ux.ibm.com>
> >
> > [ Upstream commit 908dbf0242e21dd95c69a1b0935814cd1abfc134 ]
> >
> > Checksumming of the request and sequence numbering is now done in the
> > OCC interface driver in order to keep unique sequence numbers. So
> > remove those in the hwmon driver. Also, add the command length to the
> > send_cmd function pointer, since the checksum must be placed in the
> > last two bytes of the command. The submit interface must receive the
> > exact size of the command - previously it could be rounded to the
> > nearest 8 bytes with no consequence.
> >
> > Signed-off-by: Eddie James <eajames@...ux.ibm.com>
> > Acked-by: Guenter Roeck <linux@...ck-us.net>
> > Link: https://lore.kernel.org/r/20210721190231.117185-3-eajames@linux.ibm.com
> > Signed-off-by: Joel Stanley <joel@....id.au>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> 
> If this patch is being backported then we must also backport:
> 
>   62f79f3d0eb9 ("fsi: occ: Force sequence numbering per OCC")
> 
> I was only cc'd on this one so I assume that means 62f79f3d0eb9 is not
> already in the queue.

It was not, so I have now added it, thanks.

greg k-h