linux-kernel - Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1747f5d89ca65a9e54d95e7dd77c4709@walle.cc>
Date:   Wed, 06 Jul 2022 10:57:33 +0200
From:   Michael Walle <michael@...le.cc>
To:     Claudiu.Beznea@...rochip.com
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        Nicolas.Ferre@...rochip.com, alexandre.belloni@...tlin.com,
        Cristian.Birsan@...rochip.com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

Hi Claudiu,

Am 2022-07-06 10:41, schrieb Claudiu.Beznea@...rochip.com:
> On 05.07.2022 16:06, Michael Walle wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know 
>> the content is safe
>> 
>> Now that there is driver support for the USB device, enable it.
>> 
>> Signed-off-by: Michael Walle <michael@...le.cc>
>> ---
>>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
>> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi 
>> b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> index 5a6c5f7c371a..d0d26e136c38 100644
>> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
>> @@ -200,6 +200,11 @@ &switch {
>>         status = "okay";
>>  };
>> 
>> +&udc {
>> +       atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;
> 
> Can you also add pinctrl to avoid issues described in:

Do I need a pinctrl node even if I just use it as a gpio?
Isn't that handled automatically by the
.gpio_request_enable op?

-michael