linux-kernel - Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32a2193f-aea1-6237-a993-d0ba89cce431@microchip.com>
Date:   Wed, 6 Jul 2022 08:41:08 +0000
From:   <Claudiu.Beznea@...rochip.com>
To:     <michael@...le.cc>, <robh+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>, <Nicolas.Ferre@...rochip.com>,
        <alexandre.belloni@...tlin.com>, <Cristian.Birsan@...rochip.com>
CC:     <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] ARM: dts: kswitch-d10: enable the USB device port

Hi, Michael,

On 05.07.2022 16:06, Michael Walle wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Now that there is driver support for the USB device, enable it.
> 
> Signed-off-by: Michael Walle <michael@...le.cc>
> ---
>  arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> index 5a6c5f7c371a..d0d26e136c38 100644
> --- a/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> +++ b/arch/arm/boot/dts/lan966x-kontron-kswitch-d10-mmt.dtsi
> @@ -200,6 +200,11 @@ &switch {
>         status = "okay";
>  };
> 
> +&udc {
> +       atmel,vbus-gpio = <&gpio 66 GPIO_ACTIVE_HIGH>;

Can you also add pinctrl to avoid issues described in:

commit 5ba6291086d2ae8006be9e0f19bf2001a85c9dc1
Author: Cristian Birsan <cristian.birsan@...rochip.com>
Date:   Wed Nov 18 14:00:17 2020 +0200

    ARM: dts: at91: sam9x60: add pincontrol for USB Host

    The pincontrol node is needed for USB Host since Linux v5.7-rc1. Without
    it the driver probes but VBus is not powered because of wrong pincontrol
    configuration.

    Fixes: 1e5f532c2737 ("ARM: dts: at91: sam9x60: add device tree for soc
and board")
    Signed-off-by: Cristian Birsan <cristian.birsan@...rochip.com>
    Signed-off-by: Alexandre Belloni <alexandre.belloni@...tlin.com>
    Acked-by: Ludovic Desroches <ludovic.desroches@...rochip.com>
    Link:
https://lore.kernel.org/r/20201118120019.1257580-2-cristian.birsan@microchip.com

Thank you,
Claudiu Beznea

> +       status = "okay";
> +};
> +
>  &watchdog {
>         status = "okay";
>  };
> --
> 2.30.2
>