linux-kernel - Re: [PATCH 4/5] ARM: dts: qcom: add pxo/cxo clock-output-names for ipq8064

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <62c56658.1c69fb81.87c41.6b07@mx.google.com>
Date:   Wed, 6 Jul 2022 12:22:43 +0200
From:   Christian Marangi <ansuelsmth@...il.com>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: qcom: add pxo/cxo clock-output-names for
 ipq8064

On Wed, Jul 06, 2022 at 11:29:09AM +0300, Dmitry Baryshkov wrote:
> On Tue, 5 Jul 2022 at 23:56, Christian Marangi <ansuelsmth@...il.com> wrote:
> >
> > Drivers expect to call pxo/cxo_board clock as pxo/cxo.
> > Use clock-output-names to set the correct naming for these fixed clock
> > to save drivers that are migrating to parent_data and still use
> > parent_names.
> 
> Please no. There is no reason to add these names. Let's follow the
> example of other platforms.
>

Okok... just don't like the '_board' suffix but will drop...

> >
> > Signed-off-by: Christian Marangi <ansuelsmth@...il.com>
> > ---
> >  arch/arm/boot/dts/qcom-ipq8064.dtsi | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-ipq8064.dtsi b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > index 1425a4e4283f..720e27e29627 100644
> > --- a/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > +++ b/arch/arm/boot/dts/qcom-ipq8064.dtsi
> > @@ -302,12 +302,14 @@ cxo_board: cxo_board {
> >                         compatible = "fixed-clock";
> >                         #clock-cells = <0>;
> >                         clock-frequency = <25000000>;
> > +                       clock-output-names = "cxo";
> >                 };
> >
> >                 pxo_board: pxo_board {
> >                         compatible = "fixed-clock";
> >                         #clock-cells = <0>;
> >                         clock-frequency = <25000000>;
> > +                       clock-output-names = "pxo";
> >                 };
> >
> >                 sleep_clk: sleep_clk {
> > --
> > 2.36.1
> >
> 
> 
> -- 
> With best wishes
> Dmitry

-- 
	Ansuel