linux-kernel - Re: [V3 4/7] remoteproc: qcom: pas: Check if coredump is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 Jul 2022 14:41:01 +0200
From:   Konrad Dybcio <konrad.dybcio@...ainline.org>
To:     Sibi Sankar <quic_sibis@...cinc.com>, bjorn.andersson@...aro.org
Cc:     agross@...nel.org, mathieu.poirier@...aro.org,
        dmitry.baryshkov@...aro.org, linux-arm-msm@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org,
        Siddharth Gupta <sidgup@...eaurora.org>
Subject: Re: [V3 4/7] remoteproc: qcom: pas: Check if coredump is enabled



On 5.07.2022 14:08, Sibi Sankar wrote:
> From: Siddharth Gupta <sidgup@...eaurora.org>
> 
> Client drivers need to check if coredump is enabled for the rproc before
> continuing with coredump generation. This change adds a check in the PAS
> driver.
> 
> Fixes: 8ed8485c4f05 ("remoteproc: qcom: Add capability to collect minidumps")
> Signed-off-by: Siddharth Gupta <sidgup@...eaurora.org>
> Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...ainline.org>

Konrad
>  drivers/remoteproc/qcom_q6v5_pas.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
> index 43dde151120f..d103101a5ea0 100644
> --- a/drivers/remoteproc/qcom_q6v5_pas.c
> +++ b/drivers/remoteproc/qcom_q6v5_pas.c
> @@ -92,6 +92,9 @@ static void adsp_minidump(struct rproc *rproc)
>  {
>  	struct qcom_adsp *adsp = rproc->priv;
>  
> +	if (rproc->dump_conf == RPROC_COREDUMP_DISABLED)
> +		return;
> +
>  	qcom_minidump(rproc, adsp->minidump_id);
>  }
>