linux-kernel - Re: [PATCH v1] watchdog: meson: keep running if already active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220706124139.GB492220@roeck-us.net>
Date:   Wed, 6 Jul 2022 05:41:39 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Jerome Brunet <jbrunet@...libre.com>
Cc:     Neil Armstrong <narmstrong@...libre.com>,
        Philippe Boos <pboos@...libre.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Kevin Hilman <khilman@...libre.com>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
        linux-watchdog@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-amlogic@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] watchdog: meson: keep running if already active

On Tue, Jul 05, 2022 at 09:29:35PM +0200, Jerome Brunet wrote:
> 
> On Tue 05 Jul 2022 at 16:39, Neil Armstrong <narmstrong@...libre.com> wrote:
> 
> > Hi,
> >
> > On 05/07/2022 16:24, Philippe Boos wrote:
> >> If the watchdog is already running (e.g.: started by bootloader) then
> >> the kernel driver should keep the watchdog active but the amlogic driver
> >> turns it off.
> >> Let the driver fix the clock rate then restart the watchdog if it was
> >> previously active.
> >> Reviewed-by: Jerome Brunet <jbrunet@...libre.com>
> >
> > Please drop this review tag since it was done off-list
> 
> Indeed a review was done off-list.
> 
> Reviewed-by says a review has been done. I was not aware this applied to
> public reviews only. I probably missed that, would you mind pointing me
> to that rule please ?
> 

Public or not doesn't really matter. However, you can only apply a
Reviewed-by: tag (or any tag, really) if you explicitly received one.
The exchange seems to suggest that you did not receive that tag.
Please never add any tags on your own.

On the other side, if the reviewer did send a Reviewed-by: tag off list,
I would kindly ask the reviewer to not do that in the future to avoid
misunderstandings. If you don't want your Reviewed-by: tag attached to
a patch, don't send one. Not everyone will even realize that you sent
your tag off-list, and no one can be expected to know that you didn't
really mean it when you sent your tag.

Thanks,
Guenter