linux-kernel - Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e0452b8a-0544-5647-5d3c-ce6a208f2b69@collabora.com>
Date:   Thu, 7 Jul 2022 11:51:34 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Johnson Wang <johnson.wang@...iatek.com>, ulf.hansson@...aro.org,
        robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org
Cc:     linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH] dt-bindings: mmc: Add compatible for MediaTek MT8188

Il 07/07/22 07:47, Johnson Wang ha scritto:
> This commit adds dt-binding documentation of mmc for MediaTek MT8188 SoC
> platform.
> 
> Signed-off-by: Johnson Wang <johnson.wang@...iatek.com>
> ---
>   Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> index 2a2e9fa8c188..3fbf33ad4f7c 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -32,6 +32,9 @@ properties:
>         - items:
>             - const: mediatek,mt8186-mmc
>             - const: mediatek,mt8183-mmc
> +      - items:
> +          - const: mediatek,mt8188-mmc
> +          - const: mediatek,mt8183-mmc
>         - items:
>             - const: mediatek,mt8192-mmc
>             - const: mediatek,mt8183-mmc
> 

Hello Johnson,

if I'm not wrong, this should be...
(check with dt_binding_check!)

properties:
   compatible:
     oneOf:
       - enum:
         - mediatek,mt2701-mmc
         - .... everything else ....
       - items:
         - enum:
             - mediatek,mt8186-mmc
             - ... the others ...
         - const: mediatek.mt8183-mmc

Cheers,
Angelo