linux-kernel - Re: [PATCH v4 3/3] RTC: nuvoton: Add NCT3018Y real time clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202207090650.qVcM1Juo-lkp@intel.com>
Date:   Sat, 9 Jul 2022 06:31:37 +0800
From:   kernel test robot <lkp@...el.com>
To:     Mia Lin <mimi05633@...il.com>, avifishman70@...il.com,
        tmaimon77@...il.com, tali.perry1@...il.com, venture@...gle.com,
        yuenn@...gle.com, benjaminfair@...gle.com, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, ctcchien@...oton.com,
        KWLIU@...oton.com, YSCHU@...oton.com, KFTING@...oton.com,
        JJLIU0@...oton.com, mylin1@...oton.com
Cc:     kbuild-all@...ts.01.org, openbmc@...ts.ozlabs.org,
        linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] RTC: nuvoton: Add NCT3018Y real time clock driver

Hi Mia,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on robh/for-next linus/master v5.19-rc5 next-20220708]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mia-Lin/RTC-nuvoton-Add-nuvoton-real-time-clock-driver/20220707-153317
base:   https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220709/202207090650.qVcM1Juo-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/028783fef7713ddc9f2d14a39f09741370f42e3c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Mia-Lin/RTC-nuvoton-Add-nuvoton-real-time-clock-driver/20220707-153317
        git checkout 028783fef7713ddc9f2d14a39f09741370f42e3c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/rtc/rtc-nct3018y.c:553:23: error: unterminated argument list invoking macro "MODULE_AUTHOR"
     553 | MODULE_LICENSE("GPL");
         |                       ^
>> drivers/rtc/rtc-nct3018y.c:551:1: error: expected '=', ',', ';', 'asm' or '__attribute__' at end of input
     551 | MODULE_AUTHOR(("Mia Lin <mimi05633@...il.com>");
         | ^~~~~~~~~~~~~


vim +/MODULE_AUTHOR +553 drivers/rtc/rtc-nct3018y.c

   549	
   550	MODULE_AUTHOR("Medad CChien <ctcchien@...oton.com>");
 > 551	MODULE_AUTHOR(("Mia Lin <mimi05633@...il.com>");
   552	MODULE_DESCRIPTION("Nuvoton NCT3018Y RTC driver");
 > 553	MODULE_LICENSE("GPL");

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp