linux-kernel - Re: [PATCH 2/2] pinctrl: ocelot: Fix pincfg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202207081432.wshyILwP-lkp@intel.com>
Date:   Fri, 8 Jul 2022 14:21:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Horatiu Vultur <horatiu.vultur@...rochip.com>,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, linus.walleij@...aro.org,
        kavyasree.kotagiri@...rochip.com, alexandre.belloni@...tlin.com,
        colin.foster@...advantage.com, UNGLinuxDriver@...rochip.com,
        maxime.chevallier@...tlin.com,
        Horatiu Vultur <horatiu.vultur@...rochip.com>
Subject: Re: [PATCH 2/2] pinctrl: ocelot: Fix pincfg

Hi Horatiu,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linusw-pinctrl/devel]
[also build test WARNING on linus/master v5.19-rc5 next-20220707]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Horatiu-Vultur/pinctrl-ocelot-Add-fixes-for-ocelot-driver/20220708-025029
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: i386-randconfig-m021 (https://download.01.org/0day-ci/archive/20220708/202207081432.wshyILwP-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

smatch warnings:
drivers/pinctrl/pinctrl-ocelot.c:1954 ocelot_pinctrl_create_pincfg() warn: inconsistent indenting

vim +1954 drivers/pinctrl/pinctrl-ocelot.c

ce8dc0943357a5 Alexandre Belloni 2018-01-06  1949  
076d9e71bcf8a8 Colin Foster      2021-11-19  1950  static struct regmap *ocelot_pinctrl_create_pincfg(struct platform_device *pdev)
076d9e71bcf8a8 Colin Foster      2021-11-19  1951  {
076d9e71bcf8a8 Colin Foster      2021-11-19  1952  	void __iomem *base;
076d9e71bcf8a8 Colin Foster      2021-11-19  1953  
94ef32970d4076 Michael Walle     2022-02-16 @1954  		base = devm_platform_ioremap_resource(pdev, 1);
076d9e71bcf8a8 Colin Foster      2021-11-19  1955  	if (IS_ERR(base)) {
076d9e71bcf8a8 Colin Foster      2021-11-19  1956  		dev_dbg(&pdev->dev, "Failed to ioremap config registers (no extended pinconf)\n");
076d9e71bcf8a8 Colin Foster      2021-11-19  1957  		return NULL;
076d9e71bcf8a8 Colin Foster      2021-11-19  1958  	}
076d9e71bcf8a8 Colin Foster      2021-11-19  1959  
162d70439a9da8 Horatiu Vultur    2022-07-07  1960  	return devm_regmap_init_mmio(&pdev->dev, base, &regmap_pincfg);
076d9e71bcf8a8 Colin Foster      2021-11-19  1961  }
076d9e71bcf8a8 Colin Foster      2021-11-19  1962  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp