linux-kernel - Re: [PATCH 1/2] pinctrl: ocelot: Fix pincfg for lan966x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220708082752.1745233-1-michael@walle.cc>
Date:   Fri,  8 Jul 2022 10:27:52 +0200
From:   Michael Walle <michael@...le.cc>
To:     horatiu.vultur@...rochip.com
Cc:     UNGLinuxDriver@...rochip.com, alexandre.belloni@...tlin.com,
        colin.foster@...advantage.com, kavyasree.kotagiri@...rochip.com,
        linus.walleij@...aro.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, maxime.chevallier@...tlin.com,
        Michael Walle <michael@...le.cc>
Subject: Re: [PATCH 1/2] pinctrl: ocelot: Fix pincfg for lan966x

> -static struct pinctrl_desc luton_desc = {
> -	.name = "luton-pinctrl",
> -	.pins = luton_pins,
> -	.npins = ARRAY_SIZE(luton_pins),
> -	.pctlops = &ocelot_pctl_ops,
> -	.pmxops = &ocelot_pmx_ops,
> -	.owner = THIS_MODULE,
> +static struct ocelot_match_data luton_desc = {
> +	{
.desc = {

Same for all the structs. Also it looks like it is way too big
for a stable backport:
 "It cannot be bigger than 100 lines, with context."

> +		.name = "luton-pinctrl",
> +		.pins = luton_pins,
> +		.npins = ARRAY_SIZE(luton_pins),
> +		.pctlops = &ocelot_pctl_ops,
> +		.pmxops = &ocelot_pmx_ops,
> +		.owner = THIS_MODULE,
> +	}
>  };

-michael