| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220708082129.80115-4-ligang.bdlg@bytedance.com>
Date: Fri, 8 Jul 2022 16:21:27 +0800
From: Gang Li <ligang.bdlg@...edance.com>
To: mhocko@...e.com, akpm@...ux-foundation.org, surenb@...gle.com,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...hat.com>
Cc: hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com,
borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
viro@...iv.linux.org.uk, ebiederm@...ssion.com,
keescook@...omium.org, peterz@...radead.org, acme@...nel.org,
mark.rutland@....com, alexander.shishkin@...ux.intel.com,
jolsa@...nel.org, namhyung@...nel.org, david@...hat.com,
imbrenda@...ux.ibm.com, adobriyan@...il.com,
yang.yang29@....com.cn, brauner@...nel.org,
stephen.s.brennan@...cle.com, zhengqi.arch@...edance.com,
haolee.swjtu@...il.com, xu.xin16@....com.cn,
Liam.Howlett@...cle.com, ohoono.kwon@...sung.com,
peterx@...hat.com, arnd@...db.de, shy828301@...il.com,
alex.sierra@....com, xianting.tian@...ux.alibaba.com,
willy@...radead.org, ccross@...gle.com, vbabka@...e.cz,
sujiaxun@...ontech.com, sfr@...b.auug.org.au,
vasily.averin@...ux.dev, mgorman@...e.de, vvghjk1234@...il.com,
tglx@...utronix.de, luto@...nel.org, bigeasy@...utronix.de,
fenghua.yu@...el.com, linux-s390@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
linux-mm@...ck.org, linux-perf-users@...r.kernel.org,
Gang Li <ligang.bdlg@...edance.com>
Subject: [PATCH v2 3/5] mm: add numa fields for tracepoint rss_stat
Since we add numa_count for mm->rss_stat, the tracepoint should
also be modified. Now the output looks like this:
```
sleep-660 [002] 918.524333: rss_stat: mm_id=1539334265 curr=0 type=MM_NO_TYPE type_size=0B node=2 node_size=32768B diff_size=-8192B
sleep-660 [002] 918.524333: rss_stat: mm_id=1539334265 curr=0 type=MM_FILEPAGES type_size=4096B node=-1 node_size=0B diff_size=-4096B
sleep-660 [002] 918.524333: rss_stat: mm_id=1539334265 curr=0 type=MM_NO_TYPE type_size=0B node=1 node_size=0B diff_size=-4096B
```
Signed-off-by: Gang Li <ligang.bdlg@...edance.com>
---
include/linux/mm.h | 9 +++++----
include/trace/events/kmem.h | 27 ++++++++++++++++++++-------
mm/memory.c | 5 +++--
3 files changed, 28 insertions(+), 13 deletions(-)
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 84ce6e1b1252..a7150ee7439c 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -2041,27 +2041,28 @@ static inline unsigned long get_mm_counter(struct mm_struct *mm, int member, int
return (unsigned long)val;
}
-void mm_trace_rss_stat(struct mm_struct *mm, int member, long count);
+void mm_trace_rss_stat(struct mm_struct *mm, int member, long member_count, int node,
+ long numa_count, long diff_count);
static inline void add_mm_counter(struct mm_struct *mm, int member, long value, int node)
{
long count = atomic_long_add_return(value, &mm->rss_stat.count[member]);
- mm_trace_rss_stat(mm, member, count);
+ mm_trace_rss_stat(mm, member, count, NUMA_NO_NODE, 0, value);
}
static inline void inc_mm_counter(struct mm_struct *mm, int member, int node)
{
long count = atomic_long_inc_return(&mm->rss_stat.count[member]);
- mm_trace_rss_stat(mm, member, count);
+ mm_trace_rss_stat(mm, member, count, NUMA_NO_NODE, 0, 1);
}
static inline void dec_mm_counter(struct mm_struct *mm, int member, int node)
{
long count = atomic_long_dec_return(&mm->rss_stat.count[member]);
- mm_trace_rss_stat(mm, member, count);
+ mm_trace_rss_stat(mm, member, count, NUMA_NO_NODE, 0, -1);
}
/* Optimized variant when page is already known not to be PageAnon */
diff --git a/include/trace/events/kmem.h b/include/trace/events/kmem.h
index 4cb51ace600d..7c8ad4aeb7b1 100644
--- a/include/trace/events/kmem.h
+++ b/include/trace/events/kmem.h
@@ -363,7 +363,8 @@ static unsigned int __maybe_unused mm_ptr_to_hash(const void *ptr)
EM(MM_FILEPAGES) \
EM(MM_ANONPAGES) \
EM(MM_SWAPENTS) \
- EMe(MM_SHMEMPAGES)
+ EM(MM_SHMEMPAGES) \
+ EMe(MM_NO_TYPE)
#undef EM
#undef EMe
@@ -383,29 +384,41 @@ TRACE_EVENT(rss_stat,
TP_PROTO(struct mm_struct *mm,
int member,
- long count),
+ long member_count,
+ int node,
+ long node_count,
+ long diff_count),
- TP_ARGS(mm, member, count),
+ TP_ARGS(mm, member, member_count, node, node_count, diff_count),
TP_STRUCT__entry(
__field(unsigned int, mm_id)
__field(unsigned int, curr)
__field(int, member)
- __field(long, size)
+ __field(long, member_size)
+ __field(int, node)
+ __field(long, node_size)
+ __field(long, diff_size)
),
TP_fast_assign(
__entry->mm_id = mm_ptr_to_hash(mm);
__entry->curr = !!(current->mm == mm);
__entry->member = member;
- __entry->size = (count << PAGE_SHIFT);
+ __entry->member_size = (member_count << PAGE_SHIFT);
+ __entry->node = node;
+ __entry->node_size = (node_count << PAGE_SHIFT);
+ __entry->diff_size = (diff_count << PAGE_SHIFT);
),
- TP_printk("mm_id=%u curr=%d type=%s size=%ldB",
+ TP_printk("mm_id=%u curr=%d type=%s type_size=%ldB node=%d node_size=%ldB diff_size=%ldB",
__entry->mm_id,
__entry->curr,
__print_symbolic(__entry->member, TRACE_MM_PAGES),
- __entry->size)
+ __entry->member_size,
+ __entry->node,
+ __entry->node_size,
+ __entry->diff_size)
);
#endif /* _TRACE_KMEM_H */
diff --git a/mm/memory.c b/mm/memory.c
index bb24da767f79..b085f368ae11 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -173,9 +173,10 @@ static int __init init_zero_pfn(void)
}
early_initcall(init_zero_pfn);
-void mm_trace_rss_stat(struct mm_struct *mm, int member, long count)
+void mm_trace_rss_stat(struct mm_struct *mm, int member, long member_count, int node,
+ long numa_count, long diff_count)
{
- trace_rss_stat(mm, member, count);
+ trace_rss_stat(mm, member, member_count, node, numa_count, diff_count);
}
#if defined(SPLIT_RSS_COUNTING)
--
2.20.1
Powered by blists - more mailing lists