linux-kernel - Re: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for Tegra234

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YshAt5WAG9zUkrpy@orome>
Date:   Fri, 8 Jul 2022 16:35:35 +0200
From:   Thierry Reding <thierry.reding@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     dmaengine@...r.kernel.org, jonathanh@...dia.com,
        ldewangan@...dia.com, linux-kernel@...r.kernel.org,
        linux-tegra@...r.kernel.org, p.zabel@...gutronix.de,
        vkoul@...nel.org, robh+dt@...nel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/3] dt-bindings: dmaengine: Add compatible for
 Tegra234

On Thu, Jul 07, 2022 at 08:27:27PM +0530, Akhil R wrote:
> Document the compatible string used by GPCDMA controller for Tegra234.
> 
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>  .../devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml         | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> index 9dd1476d1849..81f3badbc8ec 100644
> --- a/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/nvidia,tegra186-gpc-dma.yaml
> @@ -23,6 +23,7 @@ properties:
>      oneOf:
>        - const: nvidia,tegra186-gpcdma
>        - items:
> +          - const: nvidia,tegra234-gpcdma
>            - const: nvidia,tegra194-gpcdma
>            - const: nvidia,tegra186-gpcdma

I don't think this works because it will now fail to validate Tegra194
device trees. You'll need to create a separate set of items for
Tegra234.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)