linux-kernel - Re: [PATCH] spi: SPI_MICROCHIP_CORE should depend on SOC_MICROCHIP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <373b74b4-657c-b6b7-9532-f6602d6b2a8e@microchip.com>
Date:   Mon, 11 Jul 2022 10:33:22 +0000
From:   <Conor.Dooley@...rochip.com>
To:     <geert+renesas@...der.be>, <broonie@...nel.org>,
        <Daire.McNamara@...rochip.com>
CC:     <linux-spi@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: SPI_MICROCHIP_CORE should depend on
 SOC_MICROCHIP_POLARFIRE

On 11/07/2022 09:45, Geert Uytterhoeven wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> The Microchip "hard" FPGA SPI controller is only present on Microchip
> PolarFire SoCs.  Hence add a dependency on SOC_MICROCHIP_POLARFIRE, to
> prevent asking the user about this driver when configuring a kernel
> without Microchip PolarFire SoC support.
> 
> Fixes: 9ac8d17694b66d54 ("spi: add support for microchip fpga spi controllers")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>

Until I get the "soft" version sorted, makes sense to me.
Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

> ---
>   drivers/spi/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index e03cd16f4469079e..b1cb7fe129ff86da 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -585,6 +585,7 @@ config SPI_MESON_SPIFC
>   config SPI_MICROCHIP_CORE
>          tristate "Microchip FPGA SPI controllers"
>          depends on SPI_MASTER
> +       depends on SOC_MICROCHIP_POLARFIRE || COMPILE_TEST
>          help
>            This enables the SPI driver for Microchip FPGA SPI controllers.
>            Say Y or M here if you want to use the "hard" controllers on
> --
> 2.25.1
>