linux-kernel - Re: [PATCH] pinctrl: ralink: Check for null return of devm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkda+GhRyq5fKhBuZ209r5veM=7xyGqGqEVyQr8xQZNOa2A@mail.gmail.com>
Date:   Mon, 11 Jul 2022 14:42:48 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     williamsukatube@....com
Cc:     arinc.unal@...nc9.com, sergio.paracuellos@...il.com,
        linux-mips@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        William Dean <williamsukatube@...il.com>,
        Hacash Robot <hacashRobot@...tino.com>
Subject: Re: [PATCH] pinctrl: ralink: Check for null return of devm_kcalloc

On Sun, Jul 10, 2022 at 5:49 PM <williamsukatube@....com> wrote:

> From: William Dean <williamsukatube@...il.com>
>
> Because of the possible failure of the allocation, data->domains might
> be NULL pointer and will cause the dereference of the NULL pointer
> later.
> Therefore, it might be better to check it and directly return -ENOMEM
> without releasing data manually if fails, because the comment of the
> devm_kmalloc() says "Memory allocated with this function is
> automatically freed on driver detach.".
>
> Fixes: a86854d0c599b ("treewide: devm_kzalloc() -> devm_kcalloc()")
> Reported-by: Hacash Robot <hacashRobot@...tino.com>
> Signed-off-by: William Dean <williamsukatube@...il.com>

Patch applied for fixes!

Yours,
Linus Walleij