linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sc7280: Move wcd specific pin conf to common file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <32cffa34-1088-5e25-3051-192e3049908f@quicinc.com>
Date:   Mon, 11 Jul 2022 13:24:10 +0530
From:   Srinivasa Rao Mandadapu <quic_srivasam@...cinc.com>
To:     Stephen Boyd <swboyd@...omium.org>, <agross@...nel.org>,
        <bjorn.andersson@...aro.org>, <devicetree@...r.kernel.org>,
        <dianders@...omium.org>, <judyhsiao@...omium.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_rohkumar@...cinc.com>, <robh+dt@...nel.org>,
        <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH v2] arm64: dts: qcom: sc7280: Move wcd specific pin conf
 to common file


On 7/8/2022 11:29 PM, Stephen Boyd wrote:
Thanks for your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-07-07 05:36:21)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
>> index 32a1e78..859faaa 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-wcd9385.dtsi
>> @@ -5,6 +5,70 @@
>>    * Copyright (c) 2022, The Linux Foundation. All rights reserved.
>>    */
>>
>> +/* PINCTRL */
>> +
>> +&lpass_dmic01_clk {
>> +       drive-strength = <8>;
>> +       bias-disable;
>> +};
>> +
>> +&lpass_dmic01_clk_sleep {
>> +       drive-strength = <2>;
>> +};
>> +
>> +&lpass_dmic01_data {
>> +       bias-pull-down;
>> +};
>> +
>> +&lpass_dmic23_clk {
>> +       drive-strength = <8>;
>> +       bias-disable;
>> +};
>> +
>> +&lpass_dmic23_clk_sleep {
>> +       drive-strength = <2>;
>> +};
>> +
>> +&lpass_dmic23_data {
>> +       bias-pull-down;
>> +};
>> +
>> +&lpass_rx_swr_clk {
>> +       drive-strength = <2>;
>> +       slew-rate = <1>;
>> +       bias-disable;
>> +};
>> +
>> +&lpass_rx_swr_clk_sleep {
>> +       bias-pull-down;
>> +};
>> +
>> +&lpass_rx_swr_data {
>> +       drive-strength = <2>;
> I suspect this was discussed before, but why do we need to modify drive
> strengths on pins that aren't in output mode? I assume either rx_swr or
> tx_swr is unidirectional.

Actually this patch is just reorganization only. didn't do any 
modification of already reviewed patches.

Will test without drive strength again and post a fix patch post this 
patch accepted if required.

>
>> +       slew-rate = <1>;
>> +       bias-bus-hold;
>> +};
>> +
>> +&lpass_rx_swr_data_sleep {
>> +       bias-pull-down;
>> +};
>> +
>> +&lpass_tx_swr_clk {
>> +       drive-strength = <2>;
>> +       slew-rate = <1>;
>> +       bias-disable;
>> +};
>> +
>> +&lpass_tx_swr_clk_sleep {
>> +       bias-pull-down;
>> +};
>> +
>> +&lpass_tx_swr_data {
>> +       drive-strength = <2>;
>> +       slew-rate = <1>;
>> +       bias-bus-hold;
>> +};
>> +
>>   &mi2s1_data0 {
>>          drive-strength = <6>;
>>          bias-disable;