linux-kernel - RE: [PATCH] mmc: print clock frequency with recognization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <013f01d89583$7b320640$719612c0$@samsung.com>
Date:   Tue, 12 Jul 2022 09:08:14 +0900
From:   "Seunghui Lee" <sh043.lee@...sung.com>
To:     <ulf.hansson@...aro.org>, <u.kleine-koenig@...gutronix.de>,
        <gregkh@...uxfoundation.org>, <linux@...inikbrodowski.net>,
        <alexandre.belloni@...tlin.com>, <linux-mmc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Cc:     <grant.jung@...sung.com>, <jt77.jang@...sung.com>,
        <dh0421.hwang@...sung.com>, <junwoo80.lee@...sung.com>,
        <jangsub.yi@...sung.com>, <cw9316.lee@...sung.com>,
        <sh8267.baek@...sung.com>, <wkon.kim@...sung.com>,
        <seunghwan.hyun@...sung.com>
Subject: RE: [PATCH] mmc: print clock frequency with recognization

> -----Original Message-----
> From: Seunghui Lee <sh043.lee@...sung.com>
> Sent: Tuesday, July 5, 2022 9:51 AM
> To: ulf.hansson@...aro.org; u.kleine-koenig@...gutronix.de;
> gregkh@...uxfoundation.org; linux@...inikbrodowski.net;
> alexandre.belloni@...tlin.com; linux-mmc@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: grant.jung@...sung.com; jt77.jang@...sung.com;
> dh0421.hwang@...sung.com; junwoo80.lee@...sung.com; jangsub.yi@...sung.com;
> cw9316.lee@...sung.com; sh8267.baek@...sung.com; wkon.kim@...sung.com;
> seunghwan.hyun@...sung.com; Seunghui Lee <sh043.lee@...sung.com>
> Subject: [PATCH] mmc: print clock frequency with recognization
> 
> It's easy to figure out how fast frequency it has from the log.
> e.g. mmc0: new ultra high speed SDR104 SDXC card at address aaaa(clk
> 202000000)
> 
> Signed-off-by: Seunghui Lee <sh043.lee@...sung.com>
> ---
>  drivers/mmc/core/bus.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c index
> 58a60afa650b..3623cc27a61c 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -348,7 +348,7 @@ int mmc_add_card(struct mmc_card *card)
>  			mmc_card_ddr52(card) ? "DDR " : "",
>  			type);
>  	} else {
> -		pr_info("%s: new %s%s%s%s%s%s card at address %04x\n",
> +		pr_info("%s: new %s%s%s%s%s%s card at
> address %04x(clk %u)\n",
>  			mmc_hostname(card->host),
>  			mmc_card_uhs(card) ? "ultra high speed " :
>  			(mmc_card_hs(card) ? "high speed " : ""), @@ -356,7
> +356,8 @@ int mmc_add_card(struct mmc_card *card)
>  			(mmc_card_hs200(card) ? "HS200 " : ""),
>  			mmc_card_hs400es(card) ? "Enhanced strobe " : "",
>  			mmc_card_ddr52(card) ? "DDR " : "",
> -			uhs_bus_speed_mode, type, card->rca);
> +			uhs_bus_speed_mode, type, card->rca,
> +			card->host->ios.clock);
>  	}
> 
>  #ifdef CONFIG_DEBUG_FS
> --
> 2.29.0
Please give me any opinion or suggestion about this commit.
Normally, the SD card's bus speed depends on both host controller and internal PLL.
There are lots of host controller vendor in the market as well.
So, we can guess the exact clock speed from this commit.