linux-kernel - Re: [PATCH] mmc: print clock frequency with recognization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFqzVJ+EQYZWJG3adYEWdr=9kAXunwyKESvWqT8-L84Q9w@mail.gmail.com>
Date:   Tue, 12 Jul 2022 12:51:29 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Seunghui Lee <sh043.lee@...sung.com>
Cc:     u.kleine-koenig@...gutronix.de, gregkh@...uxfoundation.org,
        linux@...inikbrodowski.net, alexandre.belloni@...tlin.com,
        linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
        grant.jung@...sung.com, jt77.jang@...sung.com,
        dh0421.hwang@...sung.com, junwoo80.lee@...sung.com,
        jangsub.yi@...sung.com, cw9316.lee@...sung.com,
        sh8267.baek@...sung.com, wkon.kim@...sung.com,
        seunghwan.hyun@...sung.com
Subject: Re: [PATCH] mmc: print clock frequency with recognization

On Tue, 5 Jul 2022 at 02:18, Seunghui Lee <sh043.lee@...sung.com> wrote:
>
> It's easy to figure out how fast frequency it has from the log.
> e.g. mmc0: new ultra high speed SDR104 SDXC card
> at address aaaa(clk 202000000)

Well, this information is already available through debugfs and I
think that is sufficient.

Moreover, card->host->ios.clock doesn't necessarily contain that
actual clock rate, but rather the rate that is requested by the core.
To really know the rate the bus is running on,
card->host->ios.actual_clock needs to be checked too. This too is
available through debugfs.

Kind regards
Uffe

>
> Signed-off-by: Seunghui Lee <sh043.lee@...sung.com>
> ---
>  drivers/mmc/core/bus.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/core/bus.c b/drivers/mmc/core/bus.c
> index 58a60afa650b..3623cc27a61c 100644
> --- a/drivers/mmc/core/bus.c
> +++ b/drivers/mmc/core/bus.c
> @@ -348,7 +348,7 @@ int mmc_add_card(struct mmc_card *card)
>                         mmc_card_ddr52(card) ? "DDR " : "",
>                         type);
>         } else {
> -               pr_info("%s: new %s%s%s%s%s%s card at address %04x\n",
> +               pr_info("%s: new %s%s%s%s%s%s card at address %04x(clk %u)\n",
>                         mmc_hostname(card->host),
>                         mmc_card_uhs(card) ? "ultra high speed " :
>                         (mmc_card_hs(card) ? "high speed " : ""),
> @@ -356,7 +356,8 @@ int mmc_add_card(struct mmc_card *card)
>                         (mmc_card_hs200(card) ? "HS200 " : ""),
>                         mmc_card_hs400es(card) ? "Enhanced strobe " : "",
>                         mmc_card_ddr52(card) ? "DDR " : "",
> -                       uhs_bus_speed_mode, type, card->rca);
> +                       uhs_bus_speed_mode, type, card->rca,
> +                       card->host->ios.clock);
>         }
>
>  #ifdef CONFIG_DEBUG_FS
> --
> 2.29.0
>