linux-kernel - Re: [PATCH] sched/topology: change sched_energy_mutex and sched_energy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <xhsmhwnci75xx.mognet@vschneid.remote.csb>
Date:   Tue, 12 Jul 2022 15:37:30 +0100
From:   Valentin Schneider <vschneid@...hat.com>
To:     Tom Rix <trix@...hat.com>, mingo@...hat.com, peterz@...radead.org,
        juri.lelli@...hat.com, vincent.guittot@...aro.org,
        dietmar.eggemann@....com, rostedt@...dmis.org, bsegall@...gle.com,
        mgorman@...e.de, bristot@...hat.com, rafael.j.wysocki@...el.com,
        qperret@...gle.com, ionela.voinescu@....com
Cc:     linux-kernel@...r.kernel.org, Tom Rix <trix@...hat.com>
Subject: Re: [PATCH] sched/topology: change sched_energy_mutex and
 sched_energy_update to static

On 03/07/22 11:31, Tom Rix wrote:
> sparse reports
> kernel/sched/topology.c:210:1: warning: symbol 'sched_energy_mutex' was not declared. Should it be static?
> kernel/sched/topology.c:211:6: warning: symbol 'sched_energy_update' was not declared. Should it be static?
>
> When the commit listed in the fixes tag happened, the sched_energy_mutex
> and sched_energy_update variable accesses were wrapped by a function and
> the variables were and still are only accessed in the topology.c file.
> So change their storage class specifiers to static.
>
> Fixes: 31f6a8c0a471 ("sched/topology,schedutil: Wrap sched domains rebuild")
> Signed-off-by: Tom Rix <trix@...hat.com>

Reviewed-by: Valentin Schneider <vschneid@...hat.com>