linux-kernel - Re: [PATCH 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI display panel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0014fc7b-e6cd-a56b-0e3f-43660087bc2a@linaro.org>
Date:   Tue, 12 Jul 2022 23:20:15 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>,
        ~postmarketos/upstreaming@...ts.sr.ht
Cc:     martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display/panel: Add Sony Tama TD4353 JDI
 display panel

On 12/07/2022 22:50, Konrad Dybcio wrote:
> 
> 
> On 12.07.2022 22:47, Krzysztof Kozlowski wrote:
>> On 12/07/2022 22:02, Konrad Dybcio wrote:
>>> Add bindings for the display panel used on some Sony Xperia XZ2 and XZ2
>>> Compact smartphones.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
>>> ---
>>>  .../display/panel/sony,td4353-jdi.yaml        | 84 +++++++++++++++++++
>>>  1 file changed, 84 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml b/Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml
>>> new file mode 100644
>>> index 000000000000..d75abc72ad1b
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/display/panel/sony,td4353-jdi.yaml
>>> @@ -0,0 +1,84 @@
>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/display/panel/sony,td4353-jdi.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: Sony TD4353 JDI 5 / 5.7" 2160x1080 MIPI-DSI Panel
>>> +
>>> +maintainers:
>>> +  - Konrad Dybcio <konrad.dybcio@...ainline.org>
>>> +
>>> +description: |
>>> +  The Sony TD4353 JDI is a 5 (XZ2c) / 5.7 (XZ2) inch 2160x1080
>>> +  MIPI-DSI panel, used in Xperia XZ2 and XZ2 Compact smartphones.
>>> +
>>> +allOf:
>>> +  - $ref: panel-common.yaml#
>>> +
>>> +properties:
>>> +  compatible:
>>> +    enum:
>>> +      - sony,td4353-jdi-akari
>>> +      - sony,td4353-jdi-apollo
>>
>> Shouldn't the properties of panel like width and height be specified by
>> dedicated properties, instead of customizing compatible? The device is
>> "td4353-jdi", the same in both cases, isn't it?
> Not sure if it should, but in this case it probably could, the panels are
> software-compatible, yes.

There is width/height-mm property in panel-common, so if this is the
only difference - use them with only one compatible.



Best regards,
Krzysztof