linux-kernel - Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a57d278-295a-313e-ed22-7cc482e9921f@sholland.org>
Date:   Tue, 12 Jul 2022 22:01:15 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Chanwoo Choi <cwchoi00@...il.com>, Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>
Cc:     Chanwoo Choi <cw00.choi@...sung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Maxime Ripard <maxime@...no.tech>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH 2/2] dt-bindings: arm: sunxi: Add several MBUS compatibles

On 7/7/22 3:06 PM, Chanwoo Choi wrote:
> Hi Samuel,
> 
> On 22. 7. 2. 13:24, Samuel Holland wrote:
>> All of the sunxi SoCs since at least the A33 have a similar structure
>> for the MBUS and DRAM controller, but they all have minor differences in
>> MBUS port assignments and DRAM controller behavior. Give each SoC its
>> own compatible.
>>
>> Signed-off-by: Samuel Holland <samuel@...lland.org>
>> ---
>>
>>  .../bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml   | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> index 2b018feb56df..99566688d033 100644
>> --- a/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> +++ b/Documentation/devicetree/bindings/arm/sunxi/allwinner,sun4i-a10-mbus.yaml
>> @@ -29,10 +29,20 @@ properties:
>>    compatible:
>>      enum:
>>        - allwinner,sun5i-a13-mbus
>> +      - allwinner,sun8i-a33-mbus
>> +      - allwinner,sun8i-a50-mbus
>> +      - allwinner,sun8i-a83t-mbus
>>        - allwinner,sun8i-h3-mbus
>>        - allwinner,sun8i-r40-mbus
>> +      - allwinner,sun8i-v3s-mbus
>> +      - allwinner,sun8i-v536-mbus
>> +      - allwinner,sun20i-d1-mbus
>>        - allwinner,sun50i-a64-mbus
>> +      - allwinner,sun50i-a100-mbus
>>        - allwinner,sun50i-h5-mbus
>> +      - allwinner,sun50i-h6-mbus
>> +      - allwinner,sun50i-h616-mbus
>> +      - allwinner,sun50i-r329-mbus
>>  
>>    reg:
>>      minItems: 1
> 
> I have a question. 
> Are there the device drivers for the newly added compatible?

There are not DVFS drivers yet. However, the nodes are needed for their
dma-ranges property, which affects some other devices that do have drivers. And
at least for D1, the MBUS node is used for U-Boot's DRAM driver.

Regards,
Samuel