linux-kernel - Re: [PATCH v2] x86/mm/tlb: ignore f->new_tlb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <16E81A47-8BCA-4E7B-AC33-9C12B7E7A9CF@vmware.com>
Date:   Wed, 13 Jul 2022 00:50:58 +0000
From:   Nadav Amit <namit@...are.com>
To:     Hugh Dickins <hughd@...gle.com>
CC:     Dave Hansen <dave.hansen@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        X86 ML <x86@...nel.org>, Linux MM <linux-mm@...ck.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andy Lutomirski <luto@...nel.org>
Subject: Re: [PATCH v2] x86/mm/tlb: ignore f->new_tlb_gen when zero

On Jul 12, 2022, at 5:49 PM, Hugh Dickins <hughd@...gle.com> wrote:

> ⚠ External Email
> 
> On Wed, 13 Jul 2022, Nadav Amit wrote:
>> On Jul 11, 2022, at 10:39 AM, Nadav Amit <namit@...are.com> wrote:
>>> On Jul 10, 2022, at 4:28 PM, Nadav Amit <nadav.amit@...il.com> wrote:
>>>> From: Nadav Amit <namit@...are.com>
>>>> 
>>>> Commit aa44284960d5 ("x86/mm/tlb: Avoid reading mm_tlb_gen when
>>>> possible") introduced an optimization of skipping the flush if the TLB
>>>> generation that is flushed (as provided in flush_tlb_info) was already
>>>> flushed.
>>> 
>>> Dave,
>>> 
>>> Can you please review this patch today?
>>> 
>>> I feel bad (for a good reason) for breaking swap/migration.
>>> 
>>> Thanks,
>>> Nadav
>> 
>> Ping?
>> 
>> As you know, this really must go into 5.19 or otherwise aa44284960d5
>> reverted.
> 
> No, aa44284960d5 is not in 5.19-rc: it's in linux-next heading for 5.20.

Oh.. My bad. Thanks for clarifying Hugh.