linux-kernel - Re: [PATCH] iommu/mediatek: Log with dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fbd48e94-1d99-a005-1c0d-0f5416e2d42f@collabora.com>
Date:   Wed, 13 Jul 2022 10:15:55 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>, Joerg Roedel <joro@...tes.org>
Cc:     kernel@...labora.com, Matthias Brugger <matthias.bgg@...il.com>,
        Will Deacon <will@...nel.org>, Yong Wu <yong.wu@...iatek.com>,
        iommu@...ts.linux-foundation.org, iommu@...ts.linux.dev,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH] iommu/mediatek: Log with dev_err_probe when failing to
 parse dts

Il 12/07/22 23:44, Nícolas F. R. A. Prado ha scritto:
> mtk_iommu_mm_dts_parse() can fail with EPROBE_DEFER if not all larbs
> have probed yet, so use dev_err_probe() to avoid logging as an error in
> that case. Also drop the return value from the message since it's
> already printed by dev_err_probe(), and add the missing newline at the
> end.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
> 

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>