linux-kernel - Re: [PATCH 4/6] arm64: dts: imx8mm-kontron: Use upper case PMIC regulator names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02a9b4ca-baf8-9f06-12be-57853893fb50@kontron.de>
Date:   Wed, 13 Jul 2022 10:15:58 +0200
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     Heiko Thiery <heiko.thiery@...il.com>,
        Frieder Schrempf <frieder@...s.de>
Cc:     devicetree@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Shawn Guo <shawnguo@...nel.org>,
        Fabio Estevam <festevam@...il.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        NXP Linux Team <linux-imx@....com>,
        Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH 4/6] arm64: dts: imx8mm-kontron: Use upper case PMIC
 regulator names

Am 13.07.22 um 09:52 schrieb Heiko Thiery:
> Hi Frieder,
> 
> Am Mi., 13. Juli 2022 um 09:41 Uhr schrieb Frieder Schrempf <frieder@...s.de>:
>>
>> From: Frieder Schrempf <frieder.schrempf@...tron.de>
>>
>> Use upper case PMIC regulator names to comply with the bindings.
>>
>> Signed-off-by: Frieder Schrempf <frieder.schrempf@...tron.de>
>> ---
>>  .../freescale/imx8mm-kontron-n801x-som.dtsi   | 22 +++++++++----------
>>  1 file changed, 11 insertions(+), 11 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> index 2d0661cce89b..2e3d51bbf92e 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8mm-kontron-n801x-som.dtsi
>> @@ -85,7 +85,7 @@ pca9450: pmic@25 {
>>
>>                 regulators {
>>                         reg_vdd_soc: BUCK1 {
>> -                               regulator-name = "buck1";
>> +                               regulator-name = "BUCK1";
> 
> Wouldn't it be better to use the real signal or voltage rail names
> used in the schematics?

Sounds like a good idea, thanks! I will try to include in the next
version of this patchset.