linux-kernel - Re: [PATCH 0/5] KVM: x86: Clean up rmap zap helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc2c1af3-33ec-d97e-f604-12a991c7cd5e@redhat.com>
Date:   Thu, 14 Jul 2022 18:45:25 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     Sean Christopherson <seanjc@...gle.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/5] KVM: x86: Clean up rmap zap helpers

On 7/12/22 03:55, Sean Christopherson wrote:
> Clean up the rmap helpers (mostly renames) to yield a more coherent set of
> APIs, and to purge the irritating and inconsistent "rmapp" (p is for pointer)
> nomenclature.
> 
> Patch 1 is a tangentially related fix for a benign bug.
> 
> Sean Christopherson (5):
>    KVM: x86/mmu: Return a u64 (the old SPTE) from
>      mmu_spte_clear_track_bits()
>    KVM: x86/mmu: Rename rmap zap helpers to better show relationships
>    KVM: x86/mmu: Remove underscores from __pte_list_remove()
>    KVM: x86/mmu: Use innermost rmap zap helper when recycling rmaps
>    KVM: x86/mmu: Drop the "p is for pointer" from rmap helpers
> 
>   arch/x86/kvm/mmu/mmu.c | 73 +++++++++++++++++++++---------------------
>   1 file changed, 36 insertions(+), 37 deletions(-)
> 
> 
> base-commit: b9b71f43683ae9d76b0989249607bbe8c9eb6c5c

I'm not sure I dig the ____, I'll take a closer look tomorrow or next 
week since it's dinner time here.

I'm pushing what you and I collected over the past 3 weeks, for now I 
only checked that it compiles.

Paolo