linux-kernel - Re: [PATCH bpf-next v6 00/23] Introduce eBPF support for HID devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220714213912.zrotlequhpgxzdl4@MacBook-Pro-3.local>
Date:   Thu, 14 Jul 2022 14:39:12 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Benjamin Tissoires <benjamin.tissoires@...hat.com>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Jiri Kosina <jikos@...nel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <kafai@...com>,
        Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
        John Fastabend <john.fastabend@...il.com>,
        KP Singh <kpsingh@...nel.org>, Shuah Khan <shuah@...nel.org>,
        Dave Marchevsky <davemarchevsky@...com>,
        Joe Stringer <joe@...ium.io>, Jonathan Corbet <corbet@....net>,
        Tero Kristo <tero.kristo@...ux.intel.com>,
        linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org,
        linux-kselftest@...r.kernel.org, linux-doc@...r.kernel.org,
        memxor@...il.com
Subject: Re: [PATCH bpf-next v6 00/23] Introduce eBPF support for HID devices

On Tue, Jul 12, 2022 at 04:58:27PM +0200, Benjamin Tissoires wrote:
> Hi,
> 
> and after a little bit of time, here comes the v6 of the HID-BPF series.
> 
> Again, for a full explanation of HID-BPF, please refer to the last patch
> in this series (23/23).
> 
> This version sees some improvements compared to v5 on top of the
> usual addressing of the previous comments:
> - now I think every eBPF core change has a matching selftest added
> - the kfuncs declared in syscall can now actually access the memory of
>   the context
> - the code to retrieve the BTF ID of the various HID hooks is much
>   simpler (just a plain use of the BTF_ID() API instead of
>   loading/unloading of a tracing program)
> - I also added my HID Surface Dial example that I use locally to provide
>   a fuller example to users

Looking great.
Before another respin to address bits in patch 12 let's land the first ~8 patches,
since they're generic useful improvements.

Kumar, could you please help review the verifier bits?