linux-kernel - RE: [PATCH v10 1/2] thermal: Add thermal driver for Sunplus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a510b35f89034f60a05d6dbe7245e789@sphcmbx01.sunplus.com.tw>
Date:   Thu, 14 Jul 2022 05:32:06 +0000
From:   Lh Kuo 郭力豪 <lh.Kuo@...plus.com>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Li-hao Kuo <lhjeff911@...il.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "daniel.lezcano@...aro.org" <daniel.lezcano@...aro.org>,
        "amitk@...nel.org" <amitk@...nel.org>,
        "rui.zhang@...el.com" <rui.zhang@...el.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v10 1/2] thermal: Add thermal driver for Sunplus

> > +}
> > +
> > +static int sunplus_thermal_remove(struct platform_device *pdev) {
> > +	struct sp_thermal_data *sp_data = platform_get_drvdata(pdev);
> > +
> > +	thermal_zone_of_sensor_unregister(&pdev->dev, sp_data->pcb_tz);
> 
> You used devm to register, so this looks wrong and will lead to double free.
> 
>

You mean the remove function is not needed.  ??