linux-kernel - Re: [PATCH v8 01/14] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tu7kvzav.wl-tiwai@suse.de>
Date:   Thu, 14 Jul 2022 11:06:16 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Mark Brown <broonie@...nel.org>, <alsa-devel@...a-project.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
        Stefan Binding <sbinding@...nsource.cirrus.com>
Subject: Re: [PATCH v8 01/14] ALSA: hda: hda_cs_dsp_ctl: Add Library to support CS_DSP ALSA controls

On Thu, 14 Jul 2022 11:03:16 +0200,
Takashi Iwai wrote:
> 
> On Thu, 30 Jun 2022 02:23:22 +0200,
> Vitaly Rodionov wrote:
> > --- a/sound/pci/hda/Kconfig
> > +++ b/sound/pci/hda/Kconfig
> > @@ -94,6 +94,10 @@ config SND_HDA_PATCH_LOADER
> >  config SND_HDA_SCODEC_CS35L41
> >  	tristate
> >  
> > +config SND_HDA_CS_DSP_CONTROLS
> > +	tristate
> > +	depends on CS_DSP
> > +
> >  config SND_HDA_SCODEC_CS35L41_I2C
> >  	tristate "Build CS35L41 HD-audio side codec support for I2C Bus"
> >  	depends on I2C
> 
> This change alone doesn't give anything useful, unfortunately.
> 
> The above form (without prompt) is basically only to be "selected" by
> others.  And when selected, the "depends" there is just ignored, so
> it's useless.
> 
> That is, a proper way would be something like:
> 
> config SND_HDA_CS_DSP_CONTROLS
> 	tristate
> 
> config SND_HDA_SCODEC_CS35L41
> 	....
> 	select SND_HDA_CS_DSP_CONTROLS if CS_DSP
> 
> ... if you want / need to enable CONFIG_SND_HDA_CS_DSP_CONTROLS
> conditionally.

And now I see that the patch 4 has those selects (but select both
SND_HDA_CS_DSP_CONTROLS and CS_DSP).  So what we need here is to drop
the superfluous "depends on CS_DSP" and mention in the description
that the Kconfig will be actually enabled in the later patch.


thanks,

Takashi