linux-kernel - Re: [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 14 Jul 2022 18:21:41 +0800
From:   CK Hu <ck.hu@...iatek.com>
To:     Rex-BC Chen <rex-bc.chen@...iatek.com>,
        "chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "krzysztof.kozlowski+dt@...aro.org" 
        <krzysztof.kozlowski+dt@...aro.org>,
        "mripard@...nel.org" <mripard@...nel.org>,
        "tzimmermann@...e.de" <tzimmermann@...e.de>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "deller@....de" <deller@....de>,
        "airlied@...ux.ie" <airlied@...ux.ie>
CC:     "msp@...libre.com" <msp@...libre.com>,
        "granquet@...libre.com" <granquet@...libre.com>,
        Jitao Shi (石记涛) 
        <jitao.shi@...iatek.com>,
        "wenst@...omium.org" <wenst@...omium.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        LiangXu Xu (徐亮) 
        <LiangXu.Xu@...iatek.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: [PATCH v14 05/10] drm/mediatek: Add MT8195 Embedded DisplayPort
 driver

Hi, Bo-Chen:

On Thu, 2022-07-14 at 16:24 +0800, Rex-BC Chen wrote:
> On Wed, 2022-07-13 at 16:10 +0800, CK Hu wrote:
> > Hi, Bo-Chen:
> > 
> > On Tue, 2022-07-12 at 19:12 +0800, Bo-Chen Chen wrote:
> > > From: Markus Schneider-Pargmann <msp@...libre.com>
> > > 
> > > This patch adds a embedded displayport driver for the MediaTek
> > > mt8195
> > > SoC.
> > > 
> > > It supports the MT8195, the embedded DisplayPort units. It offers
> > > DisplayPort 1.4 with up to 4 lanes.
> > > 
> > > The driver creates a child device for the phy. The child device
> > > will
> > > never exist without the parent being active. As they are sharing
> > > a
> > > register range, the parent passes a regmap pointer to the child
> > > so
> > > that
> > > both can work with the same register range. The phy driver sets
> > > device
> > > data that is read by the parent to get the phy device that can be
> > > used
> > > to control the phy properties.
> > > 
> > > This driver is based on an initial version by
> > > Jitao shi <jitao.shi@...iatek.com>
> > > 
> > > Signed-off-by: Markus Schneider-Pargmann <msp@...libre.com>
> > > Signed-off-by: Guillaume Ranquet <granquet@...libre.com>
> > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@...iatek.com>
> > > ---
> > 
> > [snip]
> > 
> > > +
> > > +struct mtk_dp_timings {
> > > +	struct videomode vm;
> > > +};
> > > +
> > > +struct mtk_dp_irq_sta {
> > > +	bool hpd_inerrupt;
> > > +};
> > > +
> > > +struct mtk_dp_train_info {
> > > +	bool tps3;
> > > +	bool tps4;
> > > +	bool sink_ssc;
> > > +	bool cable_plugged_in;
> > > +	bool cable_state_change;
> > > +	bool cr_done;
> > > +	bool eq_done;
> > > +	/* link_rate is in multiple of 0.27Gbps */
> > > +	int link_rate;
> > > +	int lane_count;
> > > +	struct mtk_dp_irq_sta irq_sta;
> > 
> > There is only one member in struct mtk_dp_irq_sta, so drop struct
> > mtk_dp_irq_sta and use bool hpd_inerrupt directly here.
> > 
> 
> Hello CK,
> 
> ok, I will drop this.
> 
> > > +};
> > > +
> > > +struct mtk_dp_info {
> > > +	u32 depth;
> > > +	enum dp_pixelformat format;
> > > +	struct mtk_dp_timings timings;
> > 
> > There is only one member in struct mtk_dp_timings, so drop struct
> > mtk_dp_timings and use struct videomode vm directly here.
> > 
> 
> This structure will add more variable in following patch.
> whole struct is like,
> struct mtk_dp_timings {
> 	struct videomode vm;
> 	u8 frame_rate;
> 	u32 pix_rate_khz;
> };
> 
> I want to keep this.

I think we could just drop struct mtk_dp_timings and place these member
directly in struct mtk_dp_info.

Regards,
CK

> 
> BRs,
> Bo-Chen
> 
> 
> > Regards,
> > CK
> > 
> > > +};
> > > +
> > 
> > 
> 
>